fix: fall back to pypdfium2 page count when docling-parse returns -1#3119
Closed
majiayu000 wants to merge 1 commit intodocling-project:mainfrom
Closed
fix: fall back to pypdfium2 page count when docling-parse returns -1#3119majiayu000 wants to merge 1 commit intodocling-project:mainfrom
majiayu000 wants to merge 1 commit intodocling-project:mainfrom
Conversation
Fixes docling-project#3031 Signed-off-by: majiayu000 <1835304752@qq.com>
Contributor
|
✅ DCO Check Passed Thanks @majiayu000, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Member
|
Duplicate of #3040 |
Contributor
Author
|
Close for dup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3031
When docling-parse's C++ backend fails to parse a PDF's page tree (QPDF exception),
number_of_pages()returns-1. The currentpage_count()method returns this value directly, causingis_valid()to reject documents that pypdfium2 can read fine.Changes
page_count(): when docling-parse returns a negative count, fall back to pypdfium2's page count (len(self._pdoc)) with a warning logtest_page_count_fallback_on_parse_failuretest that mocks docling-parse failure and verifies pypdfium2 fallbackTest plan
pre-commit run --all-filespasses (Ruff + MyPy)page_count()returns pypdfium2 count when docling-parse returns -1is_valid()returns True in fallback scenario