Repository navigation
Reject unavailable .NET 12 Mono SDK toolchains - #3278
Merged
timcassell merged 2 commits intoOct 5, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9170c669-e132-46bb-8258-e448425535d6
5 tasks
Collaborator
|
If it's always rejected, we should remove the monikers also. (#3253 (comment)) |
CsProjNetToolchain.ValidateAsync always rejects Mono, MonoWasm, and MonoWasmAot runtimes targeting .NET 12 and later, so the well-known mono12.0, monowasm12.0, and monowasmaot12.0 monikers and their cached runtime and toolchain singletons are unreachable. Parsing an explicit version still resolves through the uncached fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9170c669-e132-46bb-8258-e448425535d6
timcassell
approved these changes
Oct 5, 2026
timcassell
left a comment
timcassell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @kotlarmilos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reports a validation error for Mono SDK toolchains targeting .NET 12 and later instead of requesting missing runtime packs. It respects explicit target frameworks and keeps earlier Mono runtimes and CoreCLR unchanged.
Contributes to dotnet/runtime#134397.
Note
Prepared with GitHub Copilot.