Skip to content

chore: Skip DisassemblyDiagnoserTests on macos(x64) #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filzrev wants to merge 1 commit into from
Closed

chore: Skip DisassemblyDiagnoserTests on macos(x64) #3279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/BenchmarkDotNet.IntegrationTests/DisassemblyDiagnoserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,16 @@ public class DisassemblyDiagnoserTests : BenchmarkTestExecutor
{
public DisassemblyDiagnoserTests(ITestOutputHelper output) : base(output) { }

// Helper property to skip test on `macos(x64)` because InProcessEmitToolchain test randomly failed on CI.
// See: https://github.com/dotnet/BenchmarkDotNet/issues/3086
private static bool IsRunningOnMacosX64
=> OsDetector.IsMacOS() && RuntimeInformation.GetCurrentPlatform() is Platform.X64;

public static IEnumerable<object[]> GetAllJits()
{
yield return [JitInfo.GetCurrentJit(), RuntimeInformation.GetCurrentPlatform(), InProcessEmitToolchain.Default]; // InProcess
// Add InProcessEmitToolchain except for macos(x64)
if (!IsRunningOnMacosX64)
yield return [JitInfo.GetCurrentJit(), RuntimeInformation.GetCurrentPlatform(), InProcessEmitToolchain.Default]; // InProcess

if (ContinuousIntegration.IsGitHubDraftPR())
yield break;
Expand Down Expand Up @@ -226,6 +233,9 @@ public class WithTwoBenchmarks
[Fact]
public void InProcessDisassemblyTargetsTheRunnableOfEachBenchmark()
{
if (IsRunningOnMacosX64)
return; // TODO: Replace to use Assert.Skip after migrated to xunit v3

var disassemblyDiagnoser = new DisassemblyDiagnoser(
new DisassemblyDiagnoserConfig(printSource: true, maxDepth: 3));

Expand All @@ -250,6 +260,9 @@ public void InProcessDisassemblyTargetsTheRunnableOfEachBenchmark()
[Fact]
public void InProcessDisassemblyIgnoresRunnablesOfEarlierRuns()
{
if (IsRunningOnMacosX64)
return; // TODO: Replace to use Assert.Skip after migrated to xunit v3

CanExecute<WithCalls>(ManualConfig.CreateEmpty()
.AddJob(Job.Dry.WithToolchain(InProcessEmitToolchain.Default))
.AddLogger(new OutputLogger(Output))
Expand Down
Loading