Repository navigation
Support runtime-async with IL emit - #3284
Merged
Merged
Conversation
filzrev
reviewed
Oct 6, 2026
| { | ||
| // we never want to do that in our official NuGet.org package, it's a hack | ||
| return config.Options.IsSet(ConfigOptions.KeepBenchmarkFiles) && Portability.RuntimeInformation.IsFullFramework; | ||
| return config.Options.IsSet(ConfigOptions.KeepBenchmarkFiles); |
Contributor
There was a problem hiding this comment.
Is it safe to remove IsFullFramework check here?
It looks like IsFullFramework check exists to avoid issue assemblyBuilder.Save is not supported on .NET Core.
Collaborator
Author
There was a problem hiding this comment.
This path is only reached with debug BDN, the only way for it to fail is if someone goes out of their way to test it locally on an older tfm. So it's safe enough, not worth the extra code.
filzrev
reviewed
Oct 6, 2026
| @@ -0,0 +1,45 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Contributor
There was a problem hiding this comment.
Is it able to add this project on slnx also.
Collaborator
Author
There was a problem hiding this comment.
No, it will break the CI because it's still using net10 sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime-async APIs are still experimental, but I think it's worth adding for in-process benchmarks. We can update it later if the APIs change.