Skip to content

[tests] Mark ProxyTest as Inconclusive on network failure #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 2 commits into from
May 6, 2026
+19 −12
Merged

[tests] Mark ProxyTest as Inconclusive on network failure #11288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30cf152
Mark ProxyTest.QuoteInvalidQuoteUrlsShouldWork as Inconclusive on net…
jonathanpeppers May 5, 2026
76d2109
Use Assert.Ignore instead of Assert.Inconclusive to match existing pa…
jonathanpeppers May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions tests/Mono.Android-Tests/Mono.Android-Tests/System.Net/ProxyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,27 @@ public class ProxyTest {
[Test]
public void QuoteInvalidQuoteUrlsShouldWork ()
{
string url = "http://www.msftconnecttest.com/connecttest.txt?query&foo|bar";
var request = (HttpWebRequest) WebRequest.Create (url);
request.Method = "GET";
var response = (HttpWebResponse) request.GetResponse ();
int len = 0;
using (var _r = new StreamReader (response.GetResponseStream ())) {
char[] buf = new char [4096];
int n;
while ((n = _r.Read (buf, 0, buf.Length)) > 0) {
/* ignore; we just want to make sure we can read */
len += n;
try {
string url = "http://www.msftconnecttest.com/connecttest.txt?query&foo|bar";
var request = (HttpWebRequest) WebRequest.Create (url);
request.Method = "GET";
var response = (HttpWebResponse) request.GetResponse ();
int len = 0;
using (var _r = new StreamReader (response.GetResponseStream ())) {
char[] buf = new char [4096];
int n;
while ((n = _r.Read (buf, 0, buf.Length)) > 0) {
/* ignore; we just want to make sure we can read */
len += n;
}
}
Assert.IsTrue (len > 0);
} catch (WebException ex) when (
ex.Status == WebExceptionStatus.ConnectFailure ||
ex.Status == WebExceptionStatus.NameResolutionFailure ||
ex.Status == WebExceptionStatus.Timeout) {
Assert.Ignore ($"Ignoring network failure: {ex.Message}");
}
Assert.IsTrue (len > 0);
}
}
}