[HTTP] ServicePointManager and ServicePoint#12423
Open
ManickaP wants to merge 4 commits intodotnet:mainfrom
Open
[HTTP] ServicePointManager and ServicePoint#12423ManickaP wants to merge 4 commits intodotnet:mainfrom
ManickaP wants to merge 4 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the XML API docs for System.Net.ServicePointManager and System.Net.ServicePoint to clarify behavioral details around TCP keep-alives, connection limits, and the MaxServicePoints cap.
Changes:
- Expanded
MaxServicePointsremarks to describe behavior when the limit is exceeded. - Added thread-safety notes for
SetTcpKeepAlive. - Added a note about
ServicePoint.ConnectionLimitbehavior with proxies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| xml/System.Net/ServicePointManager.xml | Clarifies MaxServicePoints behavior and documents SetTcpKeepAlive thread-safety considerations. |
| xml/System.Net/ServicePoint.xml | Adds proxy-related note for ConnectionLimit and adds SetTcpKeepAlive thread-safety guidance. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ManickaP
commented
Mar 20, 2026
ManickaP
commented
Mar 20, 2026
ManickaP
commented
Mar 20, 2026
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
gewarren
approved these changes
Mar 24, 2026
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Some minor suggestions.
|
|
||
| The <xref:System.Net.ServicePoint.ConnectionLimit> property sets the maximum number of connections that the <xref:System.Net.ServicePoint> object can make to an Internet resource. The value of the <xref:System.Net.ServicePoint.ConnectionLimit> property is set to the value of the <xref:System.Net.ServicePointManager.DefaultConnectionLimit?displayProperty=nameWithType> property when the <xref:System.Net.ServicePoint> object is created; subsequent changes to <xref:System.Net.ServicePointManager.DefaultConnectionLimit> have no effect on existing <xref:System.Net.ServicePoint> objects. | ||
|
|
||
| The connection limit does not apply to proxied connections nor proxy tunnels. |
Contributor
There was a problem hiding this comment.
Suggested change
| The connection limit does not apply to proxied connections nor proxy tunnels. | |
| The connection limit doesn't apply to proxied connections or proxy tunnels. |
|
|
||
| ## Remarks | ||
| When you reduce the <xref:System.Net.ServicePointManager.MaxServicePoints> property below the number of <xref:System.Net.ServicePoint> objects currently in existence, the <xref:System.Net.ServicePointManager> deletes the <xref:System.Net.ServicePoint> objects with the longest idle times. If the number of <xref:System.Net.ServicePoint> objects with active connections is greater than the value of <xref:System.Net.ServicePointManager.MaxServicePoints%2A>, the <xref:System.Net.ServicePointManager> object deletes the <xref:System.Net.ServicePoint> objects as they become idle. | ||
| When you reduce the <xref:System.Net.ServicePointManager.MaxServicePoints> property below the number of <xref:System.Net.ServicePoint> objects currently in existence, the <xref:System.Net.ServicePointManager> deletes the <xref:System.Net.ServicePoint> objects with the longest idle times. If the number of <xref:System.Net.ServicePoint> objects with active connections is greater than the value of <xref:System.Net.ServicePointManager.MaxServicePoints%2A>, the <xref:System.Net.ServicePointManager> object deletes the <xref:System.Net.ServicePoint> objects as they become idle. If this limit is set and more distinct <xref:System.Net.ServicePoint> instances are requested, <xref:System.Net.ServicePointManager.FindServicePoint%2A> will throw. As a result, <xref:System.Net.HttpWebRequest>s leading to new, distinct endpoints will fail. |
Contributor
There was a problem hiding this comment.
Suggested change
| When you reduce the <xref:System.Net.ServicePointManager.MaxServicePoints> property below the number of <xref:System.Net.ServicePoint> objects currently in existence, the <xref:System.Net.ServicePointManager> deletes the <xref:System.Net.ServicePoint> objects with the longest idle times. If the number of <xref:System.Net.ServicePoint> objects with active connections is greater than the value of <xref:System.Net.ServicePointManager.MaxServicePoints%2A>, the <xref:System.Net.ServicePointManager> object deletes the <xref:System.Net.ServicePoint> objects as they become idle. If this limit is set and more distinct <xref:System.Net.ServicePoint> instances are requested, <xref:System.Net.ServicePointManager.FindServicePoint%2A> will throw. As a result, <xref:System.Net.HttpWebRequest>s leading to new, distinct endpoints will fail. | |
| When you reduce the <xref:System.Net.ServicePointManager.MaxServicePoints> property below the number of <xref:System.Net.ServicePoint> objects currently in existence, the <xref:System.Net.ServicePointManager> deletes the <xref:System.Net.ServicePoint> objects with the longest idle times. If the number of <xref:System.Net.ServicePoint> objects with active connections is greater than the value of <xref:System.Net.ServicePointManager.MaxServicePoints%2A>, the <xref:System.Net.ServicePointManager> object deletes the <xref:System.Net.ServicePoint> objects as they become idle. If this limit is set and more distinct <xref:System.Net.ServicePoint> instances are requested, <xref:System.Net.ServicePointManager.FindServicePoint%2A> will throw. As a result, <xref:System.Net.HttpWebRequest> requests leading to new, distinct endpoints will fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs with more details about: