Repository navigation
[Network] Bind the NWBrowser waiting state. Fixes #26790 - #26870
Open
rolfbjarne wants to merge 1 commit into
Open
rolfbjarne wants to merge 1 commit into
rolfbjarne wants to merge 1 commit into
Conversation
Add the missing browser state value matching Network.framework, and document what waiting means for browse results and the state callback. Cover the native numeric value with a focused regression test so callers can identify it by name. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new enum-field <remarks> causes Documentation.NoRemarksOnEnumFields to fail.
1 open finding
What changed in this PR
Adds the missing NWBrowserState.Waiting binding and enables native enum validation.
Changes:
- Adds and documents
Waiting = 4. - Maps the enum to
nw_browser_state_t. - Removes the obsolete xtro exclusion.
| File | Description |
|---|---|
src/Network/NWEnums.cs |
Adds the waiting state and documentation. |
tests/xtro-sharpie/api-annotations-dotnet/common-Network.ignore |
Enables native enum validation. |
🧠 Review effort: Balanced
Comment on lines
+52
to
+53
| /// <summary>The browser is waiting for connectivity and will not deliver results until it becomes ready.</summary> | ||
| /// <remarks>A browser can enter this state after being ready. The associated error indicates why browsing is unavailable.</remarks> |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
NWBrowserState.Waiting = 4to match Network.framework'snw_browser_state_waiting. Browsers can enter this state while waiting for connectivity, including after becoming ready; callers can now identify it by name in the state changes handler.Document the enum and all its states, including the effect of waiting on browse results and the associated error. Add the native enum name and remove the obsolete xtro missing-enum exclusion so the existing enum checks cover the binding.
Fixes #26790
🤖 Pull request created by Copilot