Skip to content

add metric filter for gcperfsim test #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VincentBu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add metric filter for gcperfsim test #5186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48dfdb8
add metric filter for gcperfsim test
VincentBu Apr 3, 2026
a660bdb
Merge branch 'main' into AddMetricFilter
VincentBu Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 25 additions & 41 deletions src/benchmarks/gc/GC.Infrastructure/Configurations/GCPerfSim/LowVolatilityRuns.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,72 +68,56 @@ linux_coreruns:
output:
path: C:\InfraRuns\GCPerfSim\
columns:
- Count
- total allocated (mb)
- total pause time (msec)
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- HeapSizeAfter_Mean
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- HeapCount
- TotalNumberGCs
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationMSec_MeanWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- PauseDurationMSec_MeanWhereIsBlockingGen2
- CountIsBlockingGen2
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- PauseDurationMSec_MeanWhereIsEphemeral
- PromotedMB_MeanWhereIsGen1
- CountIsGen1
- CountIsGen0
- HeapCount
- PauseDurationMSec_Sum
- TotalAllocatedMB
- TotalNumberGCs
- Speed_MBPerMSec
- ExecutionTimeMSec
percentage_disk_remaining_to_stop_per_run: 0
all_columns:
- Count
- total allocated (mb)
- total pause time (msec)
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- HeapSizeAfter_Mean
- TotalCommittedInUse
- TotalBookkeepingCommitted
- TotalCommittedInGlobalDecommit
- TotalCommittedInFree
- TotalCommittedInGlobalFree
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- HeapCount
- TotalNumberGCs
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationMSec_MeanWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- PauseDurationMSec_MeanWhereIsBlockingGen2
- CountIsBlockingGen2
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- PauseDurationMSec_MeanWhereIsEphemeral
- PromotedMB_MeanWhereIsGen1
- CountIsGen1
- ExecutionTimeMSec
- Count
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- CountIsGen0
- HeapCount
- TotalNumberGCs
- PauseDurationMSec_Sum
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- CountIsGen1
- TotalNumberGCs
- Speed_MBPerMSec
- ExecutionTimeMSec
formats:
- markdown
Expand Down
5 changes: 5 additions & 0 deletions src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/Json.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ public static void GenerateDictionary(GCPerfSimConfiguration configuration, Dict

string propertyNameToCheck = property.Name.ToLowerInvariant();

if (!requestedPropertyNames.Contains(propertyNameToCheck))
{
continue;
}
Comment on lines +94 to +97
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the filter enabled, any Output.Columns entries that don’t match a ResultItem property name (after normalization) will be silently omitted from Results.json. Several existing GCPerfSim YAML configs still use legacy labels like Count, Speed, and total pause time (msec), which don’t map to ResultItem properties, so this change can unexpectedly drop metrics for those scenarios. Consider adding an alias/back-compat mapping (or warning on unmatched column names), or update the other GCPerfSim YAML configs to canonical property names in the same PR.

Copilot uses AI. Check for mistakes.

ComparisonResult result = resultItemComparison.GetComparison(property.Name);
comparisonResults.Add(result);
}
Expand Down
5 changes: 1 addition & 4 deletions ...benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/Markdown.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,13 +362,10 @@ public static IReadOnlyList<ComparisonResult> GenerateTable(GCPerfSimConfigurati

string propertyNameToCheck = property.Name.ToLowerInvariant();

// TODO: Add the property filter logic back in.
/*
if (!requestedPropertyNames.Contains(propertyNameToCheck))
{
//continue;
continue;
Comment on lines 363 to +367
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling this filter makes the output depend on Output.Columns matching ResultItem property names exactly. Many existing GCPerfSim YAML configs still use legacy/friendly column labels like Count, Speed, total pause time (msec), and PauseDurationSeconds_Sum (e.g., Configurations/GCPerfSim/Normal_Server.yaml), which do not correspond to any ResultItem property names, so those metrics will now be silently dropped from Results.md/Results.json for those configs. Consider adding an alias/normalization map (e.g., count→totalnumbergcs, speed→speed_mbpermsec, totalpausetimemsec→pausedurationmsec_sum) and/or emitting a warning when a requested column name doesn’t match any property, or update all affected YAML configs in the same PR to the new canonical metric names.

Copilot uses AI. Check for mistakes.
}
*/

ComparisonResult result = resultItemComparison.GetComparison(property.Name);
comparisonResults.Add(result);
Expand Down
66 changes: 25 additions & 41 deletions .../GC.Infrastructure/GC.Infrastructure/Commands/RunCommand/BaseSuite/LowVolatilityRuns.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,72 +56,56 @@ environment:

output:
columns:
- Count
- total allocated (mb)
- total pause time (msec)
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- HeapSizeAfter_Mean
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- HeapCount
- TotalNumberGCs
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationMSec_MeanWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- PauseDurationMSec_MeanWhereIsBlockingGen2
- CountIsBlockingGen2
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- PauseDurationMSec_MeanWhereIsEphemeral
- PromotedMB_MeanWhereIsGen1
- CountIsGen1
- CountIsGen0
- HeapCount
- PauseDurationMSec_Sum
- TotalAllocatedMB
- TotalNumberGCs
- Speed_MBPerMSec
- ExecutionTimeMSec
percentage_disk_remaining_to_stop_per_run: 0
all_columns:
- Count
- total allocated (mb)
- total pause time (msec)
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- HeapSizeAfter_Mean
- TotalCommittedInUse
- TotalBookkeepingCommitted
- TotalCommittedInGlobalDecommit
- TotalCommittedInFree
- TotalCommittedInGlobalFree
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- HeapCount
- TotalNumberGCs
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationMSec_MeanWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- PauseDurationMSec_MeanWhereIsBlockingGen2
- CountIsBlockingGen2
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- PauseDurationMSec_MeanWhereIsEphemeral
- PromotedMB_MeanWhereIsGen1
- CountIsGen1
- ExecutionTimeMSec
- Count
- PctTimePausedInGC
- FirstToLastGCSeconds
- HeapSizeAfter_Mean
- HeapSizeBeforeMB_Mean
- PauseDurationMSec_95PWhereIsGen0
- PauseDurationMSec_95PWhereIsGen1
- PauseDurationMSec_95PWhereIsBackground
- PauseDurationMSec_95PWhereIsBlockingGen2
- CountIsBlockingGen2
- CountIsGen0
- HeapCount
- TotalNumberGCs
- PauseDurationMSec_Sum
- TotalAllocatedMB
- Speed
- PauseDurationMSec_MeanWhereIsEphemeral
- PauseDurationSeconds_SumWhereIsGen1
- PauseDurationSeconds_Sum
- CountIsGen1
- TotalNumberGCs
- Speed_MBPerMSec
- ExecutionTimeMSec
formats:
- markdown
Expand Down
Loading