Skip to content

Emit platform-native line endings in requesting assembly chain #127945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

Emit platform-native line endings in requesting assembly chain #127945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f939860
Initial plan
Copilot May 8, 2026
cd285a6
Use platform-appropriate line endings in native assembly chain constr…
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/vm/appdomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3053,7 +3053,11 @@ void AppDomain::GetParentAssemblyChain(Assembly *pStartAssembly, SString &chain,

StackSString parentName;
pParent->GetDisplayName(parentName);
#ifdef TARGET_UNIX
chain.Append(W("\n --> "));
#else
chain.Append(W("\r\n --> "));
#endif
Comment thread
elinor-fung marked this conversation as resolved.
chain.Append(parentName);

if (pParent->IsSystem())
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/BadImageFormatException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public override string ToString()
s += Environment.NewLineConst + SR.Format(SR.IO_FileName_Name, _fileName);

if (!string.IsNullOrEmpty(_requestingAssemblyChain))
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain.ReplaceLineEndings());
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain);
Comment thread
MichalStrehovsky marked this conversation as resolved.

if (InnerException != null)
s += InnerExceptionPrefix + InnerException.ToString();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/IO/FileLoadException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public override string ToString()
s += Environment.NewLineConst + SR.Format(SR.IO_FileName_Name, FileName);

if (!string.IsNullOrEmpty(_requestingAssemblyChain))
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain.ReplaceLineEndings());
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain);
Comment thread
MichalStrehovsky marked this conversation as resolved.

if (InnerException != null)
s += Environment.NewLineConst + InnerExceptionPrefix + InnerException.ToString();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/IO/FileNotFoundException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public override string ToString()
s += Environment.NewLineConst + SR.Format(SR.IO_FileName_Name, FileName);

if (!string.IsNullOrEmpty(_requestingAssemblyChain))
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain.ReplaceLineEndings());
s += Environment.NewLineConst + SR.Format(SR.IO_FileLoad_RequestedBy, _requestingAssemblyChain);
Comment thread
MichalStrehovsky marked this conversation as resolved.

if (InnerException != null)
s += Environment.NewLineConst + InnerExceptionPrefix + InnerException.ToString();
Expand Down
Loading