Consumer: use new proto attrs in Fetcher (ListOffsets/Fetch)#2923
Merged
Conversation
Owner
dpkp
commented
Apr 26, 2026
- Consumer: use new proto attrs in Fetcher (ListOffsets/Fetch)
- KafkaNetClient: use manager.broker_version property
- kafka.util: raise from None to clean KeyError
- fetcher: prefer _manager to _client
- fix typo
- handle timestamp / leader_epoch None -> defaults
- Drop _client.connected and _client.ready checks in _create_fetch_requests
- Fix to_send / to_forget encoding
- Drop unused NoOffsetForPartitionError
- optional timeout_ms for offset lookups
- revert ListOffsets max_version = 5; add detailed TODO
- docstrings
- partition => tp
- Drop version guard from offsets_for_times (protocol will handle if necessary)
…rVersion->UnsupportedVersionError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.