Skip to content

Consumer: use new proto attrs in Fetcher (ListOffsets/Fetch)#2923

Merged
dpkp merged 15 commits into
masterfrom
dpkp/fetcher-new-proto
Apr 26, 2026
Merged

Consumer: use new proto attrs in Fetcher (ListOffsets/Fetch)#2923
dpkp merged 15 commits into
masterfrom
dpkp/fetcher-new-proto

Conversation

@dpkp
Copy link
Copy Markdown
Owner

@dpkp dpkp commented Apr 26, 2026

  • Consumer: use new proto attrs in Fetcher (ListOffsets/Fetch)
  • KafkaNetClient: use manager.broker_version property
  • kafka.util: raise from None to clean KeyError
  • fetcher: prefer _manager to _client
  • fix typo
  • handle timestamp / leader_epoch None -> defaults
  • Drop _client.connected and _client.ready checks in _create_fetch_requests
  • Fix to_send / to_forget encoding
  • Drop unused NoOffsetForPartitionError
  • optional timeout_ms for offset lookups
  • revert ListOffsets max_version = 5; add detailed TODO
  • docstrings
  • partition => tp
  • Drop version guard from offsets_for_times (protocol will handle if necessary)

@dpkp dpkp merged commit 149bd39 into master Apr 26, 2026
19 checks passed
@dpkp dpkp deleted the dpkp/fetcher-new-proto branch April 26, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant