Skip to content

consumer: guard manager.run calls with client._lock #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Apr 29, 2026
Merged

consumer: guard manager.run calls with client._lock #2940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ def offsets_by_times(self, timestamps, timeout_ms=None):
Raises:
KafkaTimeoutError if timeout_ms provided
"""
offsets = self._manager.run(self._fetch_offsets_by_times_async, timestamps, timeout_ms)
with self._client._lock:
offsets = self._manager.run(self._fetch_offsets_by_times_async, timestamps, timeout_ms)
for tp in timestamps:
if tp not in offsets:
offsets[tp] = None
Expand Down Expand Up @@ -344,7 +345,8 @@ def beginning_or_end_offset(self, partitions, timestamp, timeout_ms=None):
KafkaTimeoutError if timeout_ms provided.
"""
timestamps = dict([(tp, timestamp) for tp in partitions])
offsets = self._manager.run(self._fetch_offsets_by_times_async, timestamps, timeout_ms)
with self._client._lock:
offsets = self._manager.run(self._fetch_offsets_by_times_async, timestamps, timeout_ms)
for tp in timestamps:
offsets[tp] = offsets[tp].offset
return offsets
Expand Down
Loading