Skip to content

kafka.net: Support get_connection timeout, use for check_version #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Apr 29, 2026
+10 −5
Merged

kafka.net: Support get_connection timeout, use for check_version #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kafka/net/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ def check_version(self, node_id=None, timeout_ms=10000):
self._manager.bootstrap(timeout_ms)
if node_id is None:
return self._manager.broker_version
async def _check_version(broker_id):
conn = await self._manager.get_connection(broker_id)
async def _check_version(broker_id, timeout_ms):
conn = await self._manager.get_connection(broker_id, timeout_ms=timeout_ms)
return conn.broker_version
return self._manager.run(_check_version, node_id)
return self._manager.run(_check_version, node_id, timeout_ms)

# Request sending

Expand Down
9 changes: 7 additions & 2 deletions kafka/net/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ async def _connect(self, node, conn, reset_backoff_on_connect=True):
if self.cluster.is_bootstrap(node.node_id):
self.broker_version_data = conn.broker_version_data

def get_connection(self, node_id, pop_on_close=True, refresh_metadata_on_err=True, reset_backoff_on_connect=True):
def get_connection(self, node_id, timeout_ms=None,
pop_on_close=True,
refresh_metadata_on_err=True,
reset_backoff_on_connect=True):
if node_id is None:
raise Errors.NodeNotReadyError('No node_id provided')
elif self.connection_delay(node_id) > 0:
Expand All @@ -258,7 +261,9 @@ def get_connection(self, node_id, pop_on_close=True, refresh_metadata_on_err=Tru
conn.close_future.add_errback(lambda _: self.cluster.request_update())
self._conns[node_id] = conn
self._net.call_soon(lambda: self._connect(node, conn, reset_backoff_on_connect=reset_backoff_on_connect))
self._net.call_later(self.config['socket_connection_timeout_ms'] / 1000,
if timeout_ms is None:
timeout_ms = self.config['socket_connection_timeout_ms']
self._net.call_later(timeout_ms / 1000,
lambda: conn.close(Errors.KafkaConnectionError('Connection timed out'))
if not conn.init_future.is_done else None)
return conn
Expand Down
Loading