Consumer: use background thread for all network io; drop HeartbeatThread#2965
Open
dpkp wants to merge 7 commits into
Open
Consumer: use background thread for all network io; drop HeartbeatThread#2965dpkp wants to merge 7 commits into
dpkp wants to merge 7 commits into
Conversation
Owner
dpkp
commented
May 12, 2026
dpkp
commented
- coordinator: drop HeartbeatThread
- Consumer: Drop client._lock
- Consumer: Start net.io_thread / drop client.poll()
- Update Fetcher comment
- Dont start new heartbeat loop if closed
dpkp
force-pushed
the
dpkp/consumer-net-io
branch
from
a6f9bb1 to
3129601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.