Repository navigation
Allow runner help and tests without uv - #156
Merged
Merged
Conversation
Check parsed arguments before deciding whether uv is required. Avoid launching uv for commands that support running without it, and handle verbose output outside a virtual environment. Prepared with AI assistance; contributor review is required before upload.
dpranke
reviewed
Nov 2, 2026
| @@ -62,9 +62,6 @@ class Runner: | |||
| sys.exit(1) | |||
|
|
|||
| self.uv_path = shutil.which('uv') | |||
Owner
There was a problem hiding this comment.
Just set uv_path to None here, and populate it done on line 78.
dpranke
requested changes
Nov 2, 2026
dpranke
left a comment
dpranke
left a comment
Owner
There was a problem hiding this comment.
Looks pretty good, just one minor tweak, if that's okay.
Owner
|
Oops, must've broken this. Good catch. Of course, now that I've said we don't need tests for [ Note for any future readers: I do not expect |
Address the maintainer's review on dpranke#156. Prepared with AI assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without uv installed,
python run helpandpython run testscurrently crash in Runner.init: self.args is still None when the uv check reads self.args.command. These commands are explicitly exempt from requiring uv.Check the requirement after parsing arguments, avoid the automatic uv-launch path when uv is unavailable, and handle verbose output without an active virtual environment. Commands requiring uv keep the existing explanatory message and status 2.
The patch changes only
run. Following the feedback on #146, no package tests or runner restructuring were added.Executed verification:
run tests.Prepared with AI assistance. The contributor confirmed reviewing and vetting this commit before upload.