Fix --show-migration option not working on Rails 7.2+.#327
Merged
Conversation
olleolleolle
approved these changes
May 5, 2026
## Problem `ConnectionAdapter#migration_context` was deprecated in Rails 7.1 and removed in Rails 7.2 (rails/rails#51162). `The existing code called `connection.migration_context.current_version`, which raises `NoMethodError` on Rails 7.2+. ## Solution Use `connection.pool.migration_context` when available (Rails 7.1+), falling back to `connection.migration_context` for older versions.
OdenTakashi
force-pushed
the
fix/show-migration-rails-7.2
branch
from
fe45ac7 to
8a86229
Compare
Collaborator
Author
|
Thank you for the review and the kind words! |
drwl
approved these changes
May 8, 2026
Owner
drwl
left a comment
drwl
left a comment
There was a problem hiding this comment.
Thanks for fixing this. It's always a bit tricky as the Rails API changes across versions.
Collaborator
Author
|
Thanks for revewing this. Since this kind of issue can break differently depending on the Rails version, I think it would be good to include Rails versions in the CI matrix as well. That should help us catch compatibility issues like this earlier, especially around deprecated or removed Rails APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ConnectionAdapter#migration_contextwas deprecated in Rails 7.1 and removed in Rails 7.2 (rails/rails#51162).The existing code called
connection.migration_context.current_version, which raisesNoMethodErroron Rails 7.2+.Solution
Use
connection.pool.migration_contextwhen available (Rails 7.1+), falling back toconnection.migration_contextfor older versions.