Respect --config-path during config loading#331
Merged
Conversation
## Problem #301 added support for loading a config file from a custom path via `--config-path`. However, #293 changed `Runner#run` so that the config is loaded before CLI arguments are parsed. As a result, `--config-path` was only parsed after the config had already been loaded, meaning the custom path was not used when deciding which config file to read. ## Solution Parse CLI arguments before loading the config in `Runner#run`. This ensures that the value passed to `--config-path` is applied to `ConfigFinder.config_path` before `ConfigLoader.load_config` is called.
drwl
approved these changes
May 8, 2026
Owner
drwl
left a comment
drwl
left a comment
There was a problem hiding this comment.
Thanks for adding the detailed write up, it was easy for me to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#301 added support for loading a config file from a custom path via
--config-path. However, #293 changedRunner#runso that the config is loaded before CLI arguments are parsed.As a result,
--config-pathwas only parsed after the config had already been loaded, meaning the custom path was not used when deciding which config file to read.Solution
Parse CLI arguments before loading the config in
Runner#run.This ensures that the value passed to
--config-pathis applied toConfigFinder.config_pathbeforeConfigLoader.load_configis called.