Repository navigation
test: remove gated git module test suites - #2052
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
TASTE.md review: complies, 0 violations. The PR only deletes test files under tests/ and unused test helpers in tests/setup.ts. It doesn't change any public SDK surface in src/, so the API-shape, parity (T-1/T-2), error (T-57–T-64), deprecation (T-65–T-68) and docstring (T-69–T-74) rules don't apply.
Package ArtifactsBuilt from a066d3b. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.3-devin-1793236744-remove-gated-git-tests.0.tgz ./e2b-2.64.1-devin-1793236744-remove-gated-git-tests.0.tgzCLI ( npm install ./e2b-cli-2.24.1-devin-1793236744-remove-gated-git-tests.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.2-devin-1793236744-remove-gated-git-tests.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1793236744-remove-gated-git-tests.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.2+devin.1793236744.remove.gated.git.tests-py3-none-any.whl ./e2b-2.64.0+devin.1793236744.remove.gated.git.tests-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.10+devin.1793236744.remove.gated.git.tests-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.2+devin.1793236744.remove.gated.git.tests-py3-none-any.whl |
5e1d412 to
07f52e2
Compare
07f52e2 to
9f4d5fe
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Note
Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
9f4d5fe to
6d55eda
Compare
Summary
Removes the JS (
packages/js-sdk/tests/sandbox/git/*) and Python (packages/python-sdk/tests/shared/git/*) git module test suites. They only run whenENABLE_GIT_TESTSis set, and no CI workflow sets it, so they never run and give no coverage. The now-unusedisGitTestsEnabled/gitTestexports are dropped frompackages/js-sdk/tests/setup.ts.Split out of #2048 so the deletion can be decided on its own, e.g. held until the deprecated git module itself is removed. Test-only: no
src/change and no changeset.Verification
pnpm run format,pnpm run lint,pnpm run typecheckpass.gitTest,isGitTestsEnabledorENABLE_GIT_TESTS.Linear: SDK-410
Link to Devin session: https://app.devin.ai/sessions/98def51a61574e17908881f74f2f7ded
Open in Devin Desktop: https://app.devin.ai/desktop/session/98def51a61574e17908881f74f2f7ded?variant=devin
Requested by: @mishushakov
🟢 Devin Review found nothing to fix · View findings