Repository navigation
test(python-sdk): drop E2B_ACCESS_TOKEN from volume tests - #2140
Conversation
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
TASTE.md review: complies — 0 violations. The PR only changes Python volume tests (removing E2B_ACCESS_TOKEN setenv calls and renaming one test) and leaves no public SDK surface changed; I checked it against T-1/T-2 (the sync and async client tests change together), T-49/T-50 (config resolution) and T-51 (immutable config).
Package ArtifactsBuilt from 69ed79b. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.2-devin-1794584522-drop-access-token-env-tests.0.tgz ./e2b-2.63.1-devin-1794584522-drop-access-token-env-tests.0.tgzCLI ( npm install ./e2b-cli-2.23.1-devin-1794584522-drop-access-token-env-tests.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.2-devin-1794584522-drop-access-token-env-tests.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1794584522-drop-access-token-env-tests.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.1+devin.1794584522.drop.access.token.env.tests-py3-none-any.whl ./e2b-2.63.0+devin.1794584522.drop.access.token.env.tests-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.9+devin.1794584522.drop.access.token.env.tests-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.2+devin.1794584522.drop.access.token.env.tests-py3-none-any.whl |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2131c78272
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Summary
The SDKs stopped reading
E2B_ACCESS_TOKENin #1680. These were the last places the variable came up in CI: four Python volume tests set it withmonkeypatchto show the volume token doesn't fall back to it. This PR removes thosesetenvcalls.test_volume_token_does_not_fall_back_to_access_token_envis renamed totest_volume_token_defaults_to_none. No workflow in the repo passesE2B_ACCESS_TOKEN.Only tests change, so there's no changeset.
Link to Devin session: https://app.devin.ai/sessions/96a6d5a739bf4969baf792bb01f1b4d8
Open in Devin Desktop: https://app.devin.ai/desktop/session/96a6d5a739bf4969baf792bb01f1b4d8?variant=devin
Requested by: @mishushakov