Repository navigation
Conversation
Kylin Linux Advanced Server (银河麒麟高级服务器) V10 is an RPM/dnf, systemd distribution widely used across domestic infrastructure. Its /etc/os-release declares ID=kylin and carries no ID_LIKE, so template builds on a Kylin base currently fall through to the "unsupported base image distribution" error with no best-effort fallback. Add a kylin profile to the distro registry, RHEL/TencentOS-shaped (dnf -> microdnf -> yum install fallback, systemd at /usr/lib/systemd/systemd, wheel admin group, update-ca-trust bundle refresh) with the one verified package-name difference it shares with openEuler: Kylin ships shadow, not shadow-utils. parity_test.go gains a kylin entry for every capability; TestKylinProfile pins the id and the shadow swap; README lists Kylin. Verified against macrosan/kylin:v10-sp3-2403 (amd64): - /etc/os-release: ID="kylin", VERSION_ID="V10", no ID_LIKE - dnf transaction for the full profile package set resolves cleanly (Install 160 Packages, 45 M; no unresolved packages) - shadow-utils is absent from the repos; shadow exists (hence the swap) - dnf and yum both present; systemd, wheel group, update-ca-trust all present - go test ./.../base/distro/ passes (parity trio + generic RPM-fallback and selector coverage, plus TestKylinProfile)
AdaAibaby
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
November 13, 2026 14:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a Kylin Linux Advanced Server V10 profile to the template-build distro registry, so builds on a Kylin base image are officially supported instead of failing as an unsupported distribution.
Same pattern as the TencentOS/OpenCloudOS support (#3747 / e78f6cf): a declarative
Profilekeyed on/etc/os-releaseID, aparity_test.gocapability entry per family, a profile assertion test, and a README entry.Why
Kylin Advanced Server (银河麒麟高级服务器) V10 is an RPM/dnf, systemd distribution widely deployed across domestic infrastructure. Its
/etc/os-releasedeclaresID=kylinwith noID_LIKE, so today a Kylin base has no matching profile and no ID_LIKE fallback — provisioning exits withunsupported base image distribution.How
RHEL/TencentOS-shaped profile (
dnf → microdnf → yuminstall fallback, systemd at/usr/lib/systemd/systemd,wheeladmin group,update-ca-trustbundle refresh) with the one verified difference it shares with openEuler: Kylin shipsshadow, notshadow-utils.parity_test.gogains akylinentry for every capability;TestKylinProfilepins the id and the shadow swap; README lists Kylin.Tested (macrosan/kylin:v10-sp3-2403, amd64)
go test ./packages/orchestrator/pkg/template/build/phases/base/distro/ -v— all pass, includingTestKylinProfile, the genericTestRPMProfilesFallBackFromDnf/TestSelectorCoversIDsAndRejects, and the parity trio.Scope
Four files:
distro/distro.go,distro/parity_test.go,distro/distro_test.go,orchestrator/README.md. No behavior change for any existing distro./cc @ryan-sana Looking forward to your code review.