Repository navigation
Conversation
saikpr
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
November 13, 2026 18:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filesystem object reads currently open files with write and create flags. This rejects existing objects on read-only storage.
Use
os.OpeningetHandle, check directories through the opened handle, and map missing-open errors toErrObjectNotExist. Close rejected handles and remove the unusedcheckExistenceparameter. Reads cannot recreate an object deleted before the open.Add coverage for
WriteTo,Size, and range reads with a read-only file and directory. Skip the permission test under root. Extend missing-object coverage and check directory rejection.Validation:
getHandlefailed withpermission deniedbefore the fix. Afterward, read-only, missing-object, and directory checks passed with-race.git diff --checkpassed.make test, andmake lintattempted but blocked by the existinggithub.com/grafana/loki/pkg/pushpin:unknown revision 94c0ba7b0952.make testalso encounters a missingtesttarget inpackages/local-dev. The added package tests have not executed.Fixes #3802.