Conversation
…ing to the appropriate ro-crate profile.
…a publishedDate if it has a publisher.
douglowe
requested changes
May 5, 2026
douglowe
left a comment
douglowe
left a comment
There was a problem hiding this comment.
I wonder if we should use sh:xone instead of sh:or - see my comments in the code.
| a sh:NodeShape ; | ||
| sh:name "License present on published crates" ; | ||
| sh:description "If the root dataset is published (has schema:publisher), it SHOULD declare a license." ; | ||
| sh:targetNode ro: ; |
There was a problem hiding this comment.
Which Node is ro:? Is this the root node of the RO-Crate?
| sh:path schema:datePublished ; | ||
| sh:minCount 1 ; | ||
| ]] | ||
| ) . |
There was a problem hiding this comment.
Would it be more appropriate to use the sh:xone constraint here? If there should only be a publication date if there's a publisher then I think we don't ever want to have both of these checks to be true.
See https://www.w3.org/TR/shacl/#XoneConstraintComponent
This would then require an extra test, in which we add a schema:datePublished object without any schema:publisher object.
…for the new potential failing situation introduced by point 2.
…Entity', (2) Replaced 'sh:or' with 'sh:xone', and (3) added a test to account for the new potential failing situation introduced by point 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106.