Repository navigation
feat(ann): filter-aware candidate retrieval (#3) - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of Gitea PR #8 (
feat(ann): filter-aware candidate retrieval (#3)), rebased on the mirrored #4 tombstones work.rank.Filter— single eligibility definition for root/repo/as_of; FTS and exact scan use the same predicates.Rowcarries root/source/valid_from/valid_to;SearchFilteredfilters inside the cell scan and escalates probes until enough eligible candidates (full index for rare filters).as_ofescalateslimit*3up to a 2048-candidate cap with a loud warning.(not confirmed)from a stale index.2DPHANN2): v1 is refused withErrStaleFormatand rebuilt byensure; old WAL lines still replay.Measured on a copy of the live corpus (43,133 leafs / 39 facts), n=5: 2/13 → 6/13 queries return a fact; the 9 issue queries go 0/9 → finds onlyoffice, edelweiss.
Verified:
go vet ./...,go test ./internal/brain/ann ./internal/brain/rank, gitleaks — clean. Rollout note: v1 index is rebuilt on the nextann ensure; until then serve uses the linear scan.