[TS-3696] Use CDN image assets#2143
Merged
Merged
Conversation
ethangreen-dev
force-pushed
the
ecosystem-fetch
branch
from
96b8dad to
7e42239
Compare
ebkr
requested changes
May 5, 2026
ebkr
requested changes
May 11, 2026
ebkr
requested changes
May 12, 2026
ethangreen-dev
force-pushed
the
cdn-assets
branch
from
8c0e12e to
34cf6d2
Compare
ebkr
reviewed
May 13, 2026
ethangreen-dev
force-pushed
the
cdn-assets
branch
from
1fd40f8 to
48f3219
Compare
ethangreen-dev
force-pushed
the
ecosystem-fetch
branch
from
7e42239 to
ffa1e97
Compare
This is basically a four-step approach. The provider: 1. Checks to see if the images are bundled. 2. Checks to see if an instance of the schema is being served on localhost:1337 3. Checks to see if any images have been cached locally. 4. Retrieves the image from the CDN. Notably this also features the fire-once-and-fail-quick CDN check where it checks the connection once during startup and, if it fails, attempts steps 1-3 and then uses a default image.
ethangreen-dev
force-pushed
the
cdn-assets
branch
from
48f3219 to
90b5db2
Compare
ebkr
requested changes
May 15, 2026
ebkr
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a four-step approach. The provider:
This PR has a soft dependency on thunderstore-io/ecosystem-schema#330. I recommend cloning that specific branch to test the localhost functionality.
It is, however, hard blocked by thunderstore-io/ecosystem-schema#320
My big concern at the moment are to do with race conditions on startup. I didnt see anything strange from my own testing, but there's likely an edge case where the community list renders before image assets have been acquired. Not super experienced with vue so I'm unsure. Will perform more testing later.
And about the new assets - if needed I can move these to a separate PR.