Fix: Resolve TypeError and unintended link opening on right-click#2153
Open
Alby7503 wants to merge 1 commit into
Open
Fix: Resolve TypeError and unintended link opening on right-click#2153Alby7503 wants to merge 1 commit into
Alby7503 wants to merge 1 commit into
Conversation
Alby7503
commented
May 11, 2026
Alby7503
commented
- Fixes the TypeError 'conversion failure from null' when right-clicking UI elements (like settings tabs) without an href attribute.
- Restricts the auxclick listener to middle-clicks only to restore standard right-click context menu behavior.
- Scopes preventDefault to only handle successful link interceptions, preserving autoscroll on non-link elements.
- Adds protocol validation to openExternal IPC handler to prevent RCE vulnerabilities.
- Updates LinkProvider types to explicitly handle null/undefined values for better type safety.
- Adds unit tests for LinkImpl to prevent regressions.
- Fixes the TypeError 'conversion failure from null' when right-clicking UI elements (like settings tabs) without an href attribute. - Restricts the auxclick listener to middle-clicks only to restore standard right-click context menu behavior. - Scopes preventDefault to only handle successful link interceptions, preserving autoscroll on non-link elements. - Adds protocol validation to openExternal IPC handler to prevent RCE vulnerabilities. - Updates LinkProvider types to explicitly handle null/undefined values for better type safety. - Adds unit tests for LinkImpl to prevent regressions.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.