Skip to content

Add missing unboxing of variables in C# - #887

Open
empwilli wants to merge 3 commits into
mainfrom
empwilli/fix_missing_unboxing_csharp
Open

empwilli wants to merge 3 commits into
mainfrom
empwilli/fix_missing_unboxing_csharp

Conversation

@empwilli

Copy link
Copy Markdown
Contributor

We did not properly unbox some nullable values in transpilation,
causing the compilation to fail. Properly unbox the value.

@empwilli
empwilli requested a review from mristin November 12, 2026 10:23

@mristin mristin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add/extend existing common meta-models to catch this error in order to prevent bug regressions in the future?

We did not properly unbox some nullable values in transpilation,
causing the compilation to fail. Properly unbox the value.
The safe integer test generation did not include the necessary using
statement for the CodeAnalysis namespace. Therefore, we add the missing
using.
@empwilli
empwilli force-pushed the empwilli/fix_missing_unboxing_csharp branch from e25cf19 to c581a54 Compare November 13, 2026 14:17
@coveralls

coveralls commented Nov 13, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 43842925517

Coverage remained the same at 90.289%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 52201
Covered Lines: 47132
Line Coverage: 90.29%
Coverage Strength: 2.71 hits per line

💛 - Coveralls

@empwilli

Copy link
Copy Markdown
Contributor Author

Could you please add/extend existing common meta-models to catch this error in order to prevent bug regressions in the future?

ack, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants