Repository navigation
Allow whitespace before Go XML closing tags - #888
Merged
aaronzi merged 2 commits intoNov 16, 2026
Merged
Conversation
Contributor
|
@chris-koo can you please update your branch with the main? |
chris-koo
force-pushed
the
chriskoo/fix-go-xml-whitespace
branch
2 times, most recently
from
November 16, 2026 08:32
2f187c8 to
65af010
Compare
aaronzi
requested changes
Nov 16, 2026
aaronzi
left a comment
Member
There was a problem hiding this comment.
The new skip path can panic on malformed input and accepts characters that XML does not treat as whitespace. Details inline.
We reuse the existing whitespace and comment skipper before checking an element's closing tag so indented XML-RPC values deserialize. We add regression cases for formatting, preserved string content and unexpected children, and regenerate the Go expected output.
chris-koo
force-pushed
the
chriskoo/fix-go-xml-whitespace
branch
from
November 16, 2026 12:25
65af010 to
1e03962
Compare
aaronzi
approved these changes
Nov 16, 2026
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow formatting whitespace and comments before closing XML elements
in generated Go SDKs. We reuse the existing XML reader helper so
indented XML-RPC arrays and objects can be read without changing
string contents or accepting unexpected text and extra child elements.
We regenerate the recorded Go output to reflect this change.
This addresses the XML formatting whitespace item in #840.