Skip to content

Allow whitespace before Go XML closing tags - #888

Merged
aaronzi merged 2 commits into
eclipse-aascw:mainfrom
chris-koo:chriskoo/fix-go-xml-whitespace
Nov 16, 2026
Merged

aaronzi merged 2 commits into
eclipse-aascw:mainfrom
chris-koo:chriskoo/fix-go-xml-whitespace

Conversation

@chris-koo

Copy link
Copy Markdown
Contributor

We allow formatting whitespace and comments before closing XML elements
in generated Go SDKs. We reuse the existing XML reader helper so
indented XML-RPC arrays and objects can be read without changing
string contents or accepting unexpected text and extra child elements.

We regenerate the recorded Go output to reflect this change.

This addresses the XML formatting whitespace item in #840.

@mristin

mristin commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@chris-koo can you please update your branch with the main?

@chris-koo
chris-koo force-pushed the chriskoo/fix-go-xml-whitespace branch 2 times, most recently from 2f187c8 to 65af010 Compare November 16, 2026 08:32

@aaronzi aaronzi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new skip path can panic on malformed input and accepts characters that XML does not treat as whitespace. Details inline.

We reuse the existing whitespace and comment skipper before checking
an element's closing tag so indented XML-RPC values deserialize.

We add regression cases for formatting, preserved string content and
unexpected children, and regenerate the Go expected output.
@chris-koo
chris-koo force-pushed the chriskoo/fix-go-xml-whitespace branch from 65af010 to 1e03962 Compare November 16, 2026 12:25
@aaronzi
aaronzi merged commit a36b4bd into eclipse-aascw:main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants