Repository navigation
Fix escaping comparisons in Go XML tests - #890
Merged
aaronzi merged 1 commit intoNov 17, 2026
Merged
Conversation
aaronzi
reviewed
Nov 17, 2026
We normalize XML text escaping and distinguish string values from container indentation so equivalent literal and referenced characters compare equally, including whitespace-only strings. We preserve markup and meaningful differences between tabs, spaces, newlines and empty strings. We add round-trip regression cases and regenerate the Go golden outputs. SDK serialization and public APIs remain unchanged.
chris-koo
force-pushed
the
chriskoo/fix-go-xml-test-escaping
branch
from
November 17, 2026 15:39
6d2c77e to
6a9f45b
Compare
aaronzi
approved these changes
Nov 17, 2026
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated Go XML round-trip tests reject equivalent text representations, such as literal quotation marks and
", or literal tabs and	. This addresses the text-escaping comparison failures reported in #840.XML character references represent the same characters as their literal forms. For example, a literal tab,
	, and	represent the same string value, including when that value consists entirely of whitespace.We use the model’s XML structure to distinguish string values from container indentation and normalize their escaping consistently. We preserve meaningful differences between tabs, spaces, newlines, and empty strings while retaining the existing markup comparison.
We add round-trip regression cases and regenerate the Go golden outputs. SDK serialization behavior and public APIs remain unchanged.
Numeric formatting and XML-RPC member ordering remain outside the scope of this change.