Skip to content

Fix escaping comparisons in Go XML tests - #890

Merged
aaronzi merged 1 commit into
eclipse-aascw:mainfrom
chris-koo:chriskoo/fix-go-xml-test-escaping
Nov 17, 2026
Merged

aaronzi merged 1 commit into
eclipse-aascw:mainfrom
chris-koo:chriskoo/fix-go-xml-test-escaping

Conversation

@chris-koo

@chris-koo chris-koo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The generated Go XML round-trip tests reject equivalent text representations, such as literal quotation marks and ", or literal tabs and 	. This addresses the text-escaping comparison failures reported in #840.

XML character references represent the same characters as their literal forms. For example, a literal tab, 	, and 	 represent the same string value, including when that value consists entirely of whitespace.

We use the model’s XML structure to distinguish string values from container indentation and normalize their escaping consistently. We preserve meaningful differences between tabs, spaces, newlines, and empty strings while retaining the existing markup comparison.

We add round-trip regression cases and regenerate the Go golden outputs. SDK serialization behavior and public APIs remain unchanged.

Numeric formatting and XML-RPC member ordering remain outside the scope of this change.

We normalize XML text escaping and distinguish string values from
container indentation so equivalent literal and referenced characters
compare equally, including whitespace-only strings. We preserve markup
and meaningful differences between tabs, spaces, newlines and empty
strings.

We add round-trip regression cases and regenerate the Go golden
outputs. SDK serialization and public APIs remain unchanged.
@chris-koo
chris-koo force-pushed the chriskoo/fix-go-xml-test-escaping branch from 6d2c77e to 6a9f45b Compare November 17, 2026 15:39
@aaronzi
aaronzi merged commit 6d8d471 into eclipse-aascw:main Nov 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants