Repository navigation
Conversation
Until now the code generation for Java did not emit empty constructors. As Java does not permit to elide optional arguments, this made the construction of classes with only optional attributes tedious: users either had to use builders, or they had to provide a series of "null" values on construction. Furthermore, the pattern was inconsistent with how parameters are handled in general: we already generate constructors with only mandatory parameters, leaving out the optional ones. With this we address the issue and additionally generate empty constructors for classes for that all attributes are optinal.
With more recent versions of `com.fasterxml.jackson.core` the `fields()` accessor for json nodes has become deprecated. Instead, these the properties are now accessible via the `properties()` method. Adapt the code generation accordingly.
The java doc comments for XmlCommon contained a broken link to a generic group of functions. This caused the documentation publishing step to break. Replace the link with rendering in mono-space font.
Due to a missing import, the docs generation for Java failed, as a type referenced in the doc comments was unknown.
The java code internally would wrap/unwrap optional properties multiple times. Introduce temporary variables & lambda accessors to skip these wrap/unwrap calls and prevent the associated allocations.
Coverage Report for CI Build 44320099494Coverage increased (+0.005%) to 90.324%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The java code internally would wrap/unwrap optional properties multiple
times. Introduce temporary variables & lambda accessors to skip these
wrap/unwrap calls and prevent the associated allocations.