changing No data available message to a wheel while loading trees#19
Open
omarArm wants to merge 1 commit into
Open
changing No data available message to a wheel while loading trees#19omarArm wants to merge 1 commit into
omarArm wants to merge 1 commit into
Conversation
omarArm
changed the title
omarArm
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a loading-aware empty state to the tree table so users see a spinner while data/columns are still being resolved.
Changes:
- Introduced a
loading?: booleanprop with a default derived fromdataSource/columnDefinitionsbeing undefined. - Replaced the “No data available.” empty state with a spinner when
loadingis true. - Added CSS to theme the Ant Design spinner dots in the empty table state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| style/tree/tree.css | Styles Ant Design empty-table spinner dots and adjusts a selector formatting. |
| src/tree/browser/tree.tsx | Adds loading prop and renders a spinner in renderEmpty() while loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dataSource?: CDTTreeItem<T>[]; | ||
| /** | ||
| * Whether the tree data is still loading. | ||
| * Defaults to true while the data source or column definitions are undefined. |
| } | ||
|
|
||
| .ant-table .tree-actions > i { | ||
| .ant-table .tree-actions>i { |
Comment on lines
+670
to
+678
| renderEmpty={() => | ||
| loading ? ( | ||
| <div className={'empty-message loading-message'} role='status' aria-label='Loading data'> | ||
| <Spin size='small' /> | ||
| </div> | ||
| ) : ( | ||
| <div className={'empty-message'}>No data available.</div> | ||
| ) | ||
| } |
| const tblRef: Parameters<typeof Table>[0]['ref'] = React.useRef(null); | ||
|
|
||
| const isBackendSearch = props.search?.mode === 'backend'; | ||
| const loading = props.loading ?? (props.dataSource === undefined || props.columnDefinitions === undefined); |
Comment on lines
+670
to
+678
| renderEmpty={() => | ||
| loading ? ( | ||
| <div className={'empty-message loading-message'} role='status' aria-label='Loading data'> | ||
| <Spin size='small' /> | ||
| </div> | ||
| ) : ( | ||
| <div className={'empty-message'}>No data available.</div> | ||
| ) | ||
| } |
Contributor
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Code changes look reasonable as far as I can judge.
Please have a look at copilot feedback (especially the formatting feedback). I don't fully understand the complaint about loading. At the same time I don't see how you will use in peripheral inspector. That part would help to get the full picture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-cdt-cloud/vscode-peripheral-inspector#65