Skip to content

Fixes #198 - [E4 Extension] CSS incompatibilities with Eclipse 2026-09 - #199

Merged
fipro78 merged 2 commits into
masterfrom
issue_198
Nov 2, 2026
Merged

fipro78 merged 2 commits into
masterfrom
issue_198

Conversation

@fipro78

@fipro78 fipro78 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Dirk Fauth <dirk.fauth@googlemail.com>
@fipro78

fipro78 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

@vogella
I tested locally and it looks ok. Since you contributed the CSS changes in the current platform, I wanted to ask whether this PR matches the expectation or if I missed something else.

@vogella

vogella commented Oct 30, 2026

Copy link
Copy Markdown

Afk until next week, ping me again if I forget to check this one

@vogella

vogella commented Nov 2, 2026

Copy link
Copy Markdown

I found three things from reading the code against R4_41, I did not run it:

  1. CSS font sizes are ignored. Since 4.41, CSSSWTFontHelper.getFontData only uses the size if isSizeFromCSS() is true, and font.setSize(...) does not set that flag. This affects font-size, conversion-error-font-size, validation-error-font-size and the font shorthand. CSS2FontPropertiesHelpers.updateCSSPropertyFontSize sets the flag, and updateCSSPropertyFontComposite covers the shorthand.
  2. The minimum versions in Require-Bundle are too low. The code now needs org.eclipse.e4.ui.css.core 0.14.800 and org.eclipse.e4.ui.css.swt 0.17.100, the 4.41 versions, but the manifest still says 0.11.0 and 0.12.0. CssValues does not exist in 4.40, so NatTable 2.8 would install on older platforms and then fail at runtime with NoClassDefFoundError.
  3. org.slf4j can be removed from Import-Package. Removing the reflection took out the last use in this bundle.

Fixed review comments

Signed-off-by: Dirk Fauth <dirk.fauth@googlemail.com>
@fipro78

fipro78 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@vogella
Thanks for the hints. I have fixed your review comments and tested the font related CSS styling. With your recommended modifications it looks good now.

@fipro78
fipro78 merged commit 2f0a21b into master Nov 2, 2026
2 checks passed
@fipro78
fipro78 deleted the issue_198 branch November 2, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants