fix: make table captions visible in light mode#535
Merged
MaximilianSoerenPollak merged 1 commit intoMay 15, 2026
Merged
Conversation
The pydata-sphinx-theme styles table caption and figure figcaption with --pst-color-text-muted, which the SCORE theme sets to #FFF for the dark header background. This made captions invisible on the light page body. Add targeted overrides for these content-area elements in light mode instead of changing the shared CSS variable, which would break the header/nav styling. Fixes eclipse-score#529
AlexanderLanin
requested review from
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
MaximilianSoerenPollak
approved these changes
May 15, 2026
MaximilianSoerenPollak
merged commit f5d6e5f
into
eclipse-score:main
11 of 12 checks passed
github-project-automation
Bot
moved this from Backlog
to Done
in INF - Infrastructure Community
|
The created documentation from the pull request is available at: docu-html |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table captionandfigure figcaptionin light mode instead of changing the shared--pst-color-text-mutedvariableRoot cause
The pydata-sphinx-theme styles
table captionandfigure figcaptionwithvar(--pst-color-text-muted). The SCORE theme overrides this variable to#FFFFFFfor the dark header background — but this bleeds into content-area elements sitting on a light page body.Why not change the variable?
PR #534 changes
--pst-color-text-mutedfrom#FFFFFFto#a382c5globally, which fixes captions but recolors ~20 other elements including header nav links, the SCORE brand text, navbar icons, search elements, etc.This PR instead follows the existing pattern in
score.css— the file already overridesblockquote, breadcrumbs, sidebar links, and prev/next navigation to--pst-color-text-basefor the same reason.Fixes #529
Supersedes #534