[2231] Add the support for frames compartments#2233
Open
gcoutable wants to merge 3 commits into
Open
Conversation
gcoutable
force-pushed
the
gco/enh/frames-compartment
branch
2 times, most recently
from
f5d3c67 to
b07a11f
Compare
gcoutable
force-pushed
the
gco/enh/frames-compartment
branch
2 times, most recently
from
6ad6bea to
a0e1c74
Compare
AxelRICHARD
reviewed
May 22, 2026
| name = "New Require constraint"; | ||
| } else if (SysmlPackage.eINSTANCE.getRequirementUsage_FramedConcern().equals(eReference) | ||
| || SysmlPackage.eINSTANCE.getRequirementDefinition_FramedConcern().equals(eReference)) { | ||
| name = "New framed concern"; |
Member
There was a problem hiding this comment.
it would be better to have consistency between tool names, so in this case it would be "New Framed concern"
Member
|
I will handle the remark myself, rebase and merge the PR thank you |
AxelRICHARD
force-pushed
the
gco/enh/frames-compartment
branch
from
a0e1c74 to
e9ceedc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests