Repository navigation
Avoid redundant per-call work in blink reporter and phpdoc typo fixer - #186
Merged
Merged
Conversation
relativePath called os.Getwd() for every reported file; resolve the cwd once before the loop and pass it in. fpntFixTypos recompiled its @PARAM pattern on every call; memoize the per-typo-name regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent performance cleanups. No behavior change.
reporter.relativePathcalledos.Getwd()once per reported file, inside the diff loop. The cwd is now resolved once before the loop and passed in; an empty cwd falls back to the original path, as before.fpntFixTyposrecompiled its@param ... <name>regex on every call. The pattern depends only on the typo name, so it is now memoized per name in a concurrency-safe cache.The larger O(n^2) token-stream rework is handled separately in its own PR.