Repository navigation
Add context cancellation and error aggregation to blink runner - #191
Merged
Merged
Conversation
Run now takes a context and stops feeding files when it is cancelled, so the CLI can be interrupted cleanly (main wires it to SIGINT/SIGTERM). File errors from all workers are collected and returned with errors.Join instead of keeping only the first and dropping the rest.
TomasVotruba
enabled auto-merge (squash)
October 9, 2026 19:24
TomasVotruba
force-pushed
the
blink-runner-context
branch
from
October 9, 2026 19:24
8fdbb55 to
0492b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robustness improvements to the runner. The CLI now stops cleanly on interrupt and reports every failing file instead of just the first.
runner.Runtakes acontext.Contextand stops feeding files once it is cancelled; in-flight files finish, then workers drain.mainwires the context to SIGINT/SIGTERM viasignal.NotifyContext, so Ctrl-C ends a run without a torn write.errors.Join, replacing the previoussync.Once/firstErrthat kept only the first error and silently dropped the rest.Independent of the quick-win cleanup PR; both touch
runner.goimports, so one will need a trivial rebase after the other merges.