Unsupported types raise Protocol.Undefined#187
Open
nhudson3SA wants to merge 1 commit intoedgurgel:mainfrom
Open
Unsupported types raise Protocol.Undefined#187nhudson3SA wants to merge 1 commit intoedgurgel:mainfrom
nhudson3SA wants to merge 1 commit intoedgurgel:mainfrom
Conversation
a3kov
reviewed
Dec 30, 2025
|
|
||
| def match(_, _), do: {:error, :not_found} | ||
| def match(data, _) do | ||
| raise Protocol.UndefinedError, |
Contributor
There was a problem hiding this comment.
If you want to raise, you must at least check that strict mode is on.
Owner
There was a problem hiding this comment.
Yeah we might want to return a different error tuple here and use Context.put_errors to add a new error IF strict_variables=true. If not true we just ignore
nhudson3SA
force-pushed
the
feat/raise-protocol-not-impl
branch
from
502fa70 to
700bbc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for implementation of #185
{Issue was made under personal account)