-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update to Python 3.11/3.12 and Django 4.2/5.2 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gi-ron
wants to merge
6
commits into
main
Choose a base branch
from
sgb/upgrade-python-django-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9a8ec7e
feat: add support for Python 3.11/3.12 and Django 4.2/5.2
Gi-ron 4e5392a
fix: commitlint workflow
Gi-ron 5a56827
fix: update matrix ubuntu version
Gi-ron 48b2e9d
feat: upgrade pip and setuptools in workflow
Gi-ron f5f9e56
feat: adding feedback pr
Gi-ron 8fd3e1f
fix: update ci workflow with correct versions
Gi-ron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,25 @@ | ||
| # Run commitlint on the commit messages in a pull request. | ||
|
|
||
| name: Lint Commit Messages | ||
|
|
||
| on: | ||
| - pull_request | ||
| pull_request: | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| commitlint: | ||
| uses: edx/.github/.github/workflows/commitlint.yml@master | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out the repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 100 | ||
|
|
||
| - name: Download configuration | ||
| run: | | ||
| wget --no-verbose -O commitlint.config.mjs \ | ||
| https://raw.githubusercontent.com/openedx/edx-lint/HEAD/edx_lint/files/commitlint.config.js | ||
|
|
||
| - name: Run commitlint | ||
| uses: wagoid/commitlint-github-action@v6 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gi-ron I’m curious why this step and the related changes in this action are needed now. Was the action not working properly before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was that the default configuration file (downloaded from openedx/edx-lint) uses ES module syntax (export default), but the action expects CommonJS (module.exports). This caused a syntax error when the action tried to run. I’m not entirely sure if this failure was already present before (I didn’t run the action on previous commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gi-ron are we sure there is not a cleaner way to run this workflow?
If not, I'm ok with merging this but first I would like us to do a double check