Skip to content

chore: release flow — SemVer tags + Changesets v3/action v2 - #58

Merged
edwardloopez merged 1 commit into
mainfrom
chore/release-flow-changesets-v3
Nov 12, 2026
Merged

edwardloopez merged 1 commit into
mainfrom
chore/release-flow-changesets-v3

Conversation

@edwardloopez

Copy link
Copy Markdown
Owner

Summary

  • Tags stay vX.Y.Z via changeset publish --no-git-tag + scripts/git-tag-release.mjs (pnpm workspace ≠ Changesets root mode)
  • CI security audit is non-blocking with ::warning:: (no red annotation)
  • Documented feature → Version PR → publish gate in CONTRIBUTING
  • Migrated to @changesets/cli@3, changelog-github compatible, config schema v4, and changesets/action@v2 (pinned SHA)
  • Example dep uses workspace:* for Changesets v3; closed Dependabot chore(deps): bump changesets/action from 1 to 2 #52 as superseded

Test plan

  • Local dry-run: getPackages → custom tag path v*; changeset status/version with zero changesets exit 1 (expected for v3)
  • pnpm typecheck + targeted jest suites pass
  • CI green on this PR (lint / test / security)
  • Do not merge any Version Packages PR / do not publish from this migration

Made with Cursor

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T02:36:26.593634Z a7b261e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7b261e00f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json Resolved
@edwardloopez
edwardloopez force-pushed the chore/release-flow-changesets-v3 branch from a7b261e to 0c949b6 Compare November 12, 2026 02:37
@edwardloopez

Copy link
Copy Markdown
Owner Author

Correcto: este PR no debe llevar changeset (solo tooling/release).

verify-changeset fallaba porque también exigía changeset al tocar package.json. Ahora solo exige changeset si cambia src/ (alineado con CONTRIBUTING).

También endurecí un test flaky de timing en CI (99ms vs >= 100).

@edwardloopez
edwardloopez force-pushed the chore/release-flow-changesets-v3 branch from 0c949b6 to b986ab8 Compare November 12, 2026 02:45
@edwardloopez

Copy link
Copy Markdown
Owner Author

Fix Codex P2: con --no-git-tag, action v2 nunca veía eventos git-tag → `published` quedaba en false y se saltaba el GitHub Release.

`scripts/git-tag-release.mjs` ahora escribe el evento NDJSON en `CHANGESETS_OUTPUT` al crear el tag `vX.Y.Z`, y el workflow pone `push-git-tags: false` (el script ya hace el push).

@edwardloopez
edwardloopez force-pushed the chore/release-flow-changesets-v3 branch from b986ab8 to 9be7d67 Compare November 12, 2026 03:18
Use custom publish tagging for vX.Y.Z, action v2 inputs, non-blocking
audit warnings, and document the Version PR publish gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@edwardloopez
edwardloopez force-pushed the chore/release-flow-changesets-v3 branch from 9be7d67 to dad5b75 Compare November 12, 2026 03:35
@edwardloopez
edwardloopez merged commit 3775484 into main Nov 12, 2026
5 checks passed
@edwardloopez
edwardloopez deleted the chore/release-flow-changesets-v3 branch November 12, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant