Repository navigation
Conversation
The release action uploads the icon and screenshots that emdash-plugin.jsonc lists under release.artifacts, and reads both from the working directory. The publish job only downloaded the bundle, so releases reached the registry without listing images. The checkout runs first, because it cleans the workspace and would remove a bundle downloaded before it. Closes #36
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36.
The registry's release action uploads the icon and screenshots that
emdash-plugin.jsonclists underrelease.artifacts(emdash-cms/emdash#4467, merged 2026-11-06), and reads the manifest and the image files from the working directory. Ourpublishjob only downloaded the bundle, so 0.3.1 and 0.3.2 are in the registry without listing images.The checkout is the job's first step: it cleans the workspace and would remove a bundle downloaded before it.
persist-credentials: false, nothing is installed or built in the job that holdsid-token.Not checked: the upload itself, which only a release run shows. Done when the next release's listing has the icon and five screenshots.