Skip to content

ColumnView preview: fix reloading subfolder#2790

Merged
ryonakano merged 3 commits into
mainfrom
jeremypw/preview/fix-reload-subfolder
Jun 3, 2026
Merged

ColumnView preview: fix reloading subfolder#2790
ryonakano merged 3 commits into
mainfrom
jeremypw/preview/fix-reload-subfolder

Conversation

@jeremypw
Copy link
Copy Markdown
Contributor

@jeremypw jeremypw commented May 4, 2026

Fixes #2788

The issue was found to be caused by a line of code left over from the previous preview implementation where the preview was added to a slot. Removing this line fixed the issue.

@jeremypw jeremypw added this to the 7.3.2 milestone May 4, 2026
@jeremypw jeremypw marked this pull request as ready for review May 8, 2026 16:25
@jeremypw jeremypw mentioned this pull request May 31, 2026
8 tasks
Copy link
Copy Markdown
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the linked issue.

Also, this fixes an issue (not sure if reported or related to the linked one) that rapidly changing selected folder in the column view easily crashes Files.

@ryonakano ryonakano enabled auto-merge (squash) June 3, 2026 23:06
@ryonakano ryonakano merged commit 44262ff into main Jun 3, 2026
4 checks passed
@ryonakano ryonakano deleted the jeremypw/preview/fix-reload-subfolder branch June 3, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miller columns: the right-hand column appears blank

2 participants