Port ProcessTreeView to GTK4 by stsdc · Pull Request #525 · elementary/monitor

stsdc · 2026-02-26T20:51:39Z

The intend is to future proof the process list and lay some ground for a tree view reintroduction.

…Name column

…dering if integer values do not change on the view

danirabbit · 2026-03-05T17:14:37Z

+public class Monitor.ProcessTreeView : Granite.Bin {
+    private Gtk.ColumnView list;
+
+    public ProcessTreeView (TreeViewModel model) {


Can we do this gobject style?

But is it necessary in this case? Model is used only in this constructor.

It's maybe not "necessary" but it's best practice for classes to use gobject style construction

danirabbit

Made a few comments about code style etc

Co-authored-by: Danielle Foré <danielle@elementary.io>

stsdc · 2026-05-10T15:42:14Z

I have binded all the values from a ProcessRowData to the rows in the ColumnView. This fixed unnecessary list jumps on every update. Thanks to @alice-mkh and sadlyascii for the help!

ryonakano

Just take a glance at the changes, but leaving some comments that I noticed or concerned.

ryonakano · 2026-05-18T12:54:41Z

@@ -0,0 +1,11 @@
+


Our source code in the elementary Organization usually have a copyright header here, so we should add it here. The same comment goes to the other new files added in this PR.

ryonakano · 2026-05-18T12:56:48Z

+        pid_item_factory.unbind.connect (pid_item_unbind_factory);
+
+
+        var name_column = new Gtk.ColumnViewColumn (_("Process Name"), name_item_factory) {


We need to add this file to POTFILES because it have translatable strings like here.

ryonakano · 2026-05-18T14:09:45Z

+            _needle = value;
+        }
+    }
+    public Gtk.FilterListModel model_out;


Can't this be { get; private set; } for lesser scope?

ryonakano · 2026-05-18T14:24:17Z

+    private Gtk.AnyFilter any_filter;
+    private Gtk.StringFilter name_filter;
+    private Gtk.StringFilter cmd_filter;
+    private Gtk.CustomFilter pid_filter;


Is there any reason this is a instance variable instead of a local variable in the constructor? It's not used out of the constructor.

ryonakano · 2026-05-18T14:28:05Z

+            name_filter.search = value;
+            cmd_filter.search = value;


What about using GLib.Object.bind_property() instead of making these variables as instance variables? I'm suggesting this in favor of lesser scope and also because substituting these variables in the setter feels like out of scope of an setter for me.

Something like this (note that I've neither compiled nor tested this):

public class Monitor.TreeViewFilter : GLib.Object { public string needle { get; set; } public Gtk.FilterListModel model_out; private Gtk.AnyFilter any_filter; private Gtk.CustomFilter pid_filter; public TreeViewFilter (GLib.ListModel? model) { var name_filter = build_str_filter ("name"); var cmd_filter = build_str_filter ("cmd"); // since the pid property is an int, we need to use a custom filter to convert it to a string pid_filter = new Gtk.CustomFilter ((obj) => { var item = (ProcessRowData) obj; bool pid_found = item.pid.to_string ().contains (needle.casefold ()) || false; return pid_found; }); any_filter = new Gtk.AnyFilter (); any_filter.append (name_filter); any_filter.append (cmd_filter); any_filter.append (pid_filter); model_out = new Gtk.FilterListModel (model, any_filter); bind_property ("needle", name_filter, "search", SYNC_CREATE); bind_property ("needle", cmd_filter, "search", SYNC_CREATE); } private Gtk.StringFilter build_str_filter (string column_name) { var expression = new Gtk.PropertyExpression (typeof (ProcessRowData), null, column_name); return new Gtk.StringFilter (expression) { ignore_case = true, match_mode = SUBSTRING, search = needle }; } }

ryonakano · 2026-05-18T15:01:19Z

+        var label = (Gtk.Label) box.get_last_child ();
+        var icon = (Gtk.Image) box.get_first_child ();


I think this heavily depends on implementation of name_item_setup_factory(), which makes difficult for future changes. I think we should create a new widget class that based on Gtk.Box and contains label and icon.

ryonakano · 2026-05-18T15:05:51Z

    public ProcessManager process_manager;
-    private Gee.Map<int, Gtk.TreeIter ? > process_rows;
+
+    public TreeViewFilter filtered;


I'm not sure if Vala allows this, but can't we make this { get; private set; } while keeping access to its needle property?

ryonakano · 2026-05-18T15:06:07Z

-    private Gee.Map<int, Gtk.TreeIter ? > process_rows;
+
+    public TreeViewFilter filtered;
+    public Gtk.SingleSelection selection_model;


Can't this be { get; private set; }?

ryonakano · 2026-05-18T15:13:41Z

+                item.memory = process.mem_usage;
+                sorter.changed (DIFFERENT);
+            } else {
+                debug ("Failed to find process row for pid %d", pid);


Is there any reason this is debug(), which means the message is not shown by default without G_MESSAGES_DEBUG environment variable is set?

Also I recommend to use the early return pattern so that the expected route doesn't get too nested. Something like this:

uint pos; if (!store.find (process_row, out pos)) { debug ("Failed to find process row for pid %d", pid); return; } var item = (ProcessRowData) store.get_item (pos); item.cpu = (int) process.cpu_percentage; item.memory = process.mem_usage; sorter.changed (DIFFERENT);

ryonakano · 2026-05-18T15:17:46Z

-    private void update_model () {
+    public void update_model () {


Why is this now a public method?

stsdc added 10 commits February 11, 2026 18:28

[wip] gtk4-treeview

83bf4bf

[wip] add signal list factory

35e7641

ProcessTreeView: Show process name and add sorting

236bc00

ProcessTreeView: Reintroduce cpu and memory columns

21f5432

ProcessTreeView: Reintroduce PID column

98b801f

ProcessTreeView: reintroduce process_selected signal

780a157

ProcessTreeView: use selected-item property to watch

1bd04dd

ProcessTreeView: update selection model connection and expand Proces …

a05b0bd

…Name column

TreeViewModel: update values in the store

ade573e

ProcessTreeView: introduce initial filtering by name

ee8b5e1

stsdc linked an issue Feb 26, 2026 that may be closed by this pull request

Rewrite process tree view #455

Open

stsdc added 8 commits February 28, 2026 18:20

ProcessTreeView: process filtering works

8e6d601

ProcessTreeView: reverse sorting for numeric values; fix process reor…

9907a24

…dering if integer values do not change on the view

ProcessTreeView: show process icons

b6c2933

TreeViewModel: refactor

d37b1e1

TreeViewModel: refactor

ead83cd

CPUProcessTreeView: adios!

a0927f2

ProcessView: remove obsolete commented out filtering function

6b66db3

cleanup

952481b

stsdc requested a review from a team March 5, 2026 12:27

stsdc marked this pull request as ready for review March 5, 2026 13:11

stsdc added this to OS 9 Mar 5, 2026

stsdc moved this to Needs Review in OS 9 Mar 5, 2026

danirabbit reviewed Mar 5, 2026

View reviewed changes

Comment thread src/meson.build Outdated

danirabbit reviewed Mar 5, 2026

View reviewed changes

Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated

danirabbit reviewed Mar 5, 2026

View reviewed changes

danirabbit requested a review from a team March 5, 2026 17:20

stsdc added 2 commits March 6, 2026 11:42

Remove unused functions

d5b2492

Remove unneeded GTK namespaces

336bde8

stsdc and others added 8 commits March 6, 2026 11:49

Use correct casting syntax

af1686b

Co-authored-by: Danielle Foré <danielle@elementary.io>

Remove old treeview functionality

63e94ba

Fix code style

6424b20

Use format_size; Move some setup factories to a separate reusable method

92d3a60

Convert lambdas to methods

0c921f1

Remove a leftover comment

932954a

Fix memory size

131fe82

Localize column_view object

74615a0

stsdc commented Mar 15, 2026

View reviewed changes

Comment thread src/Models/TreeViewModel.vala Outdated

danirabbit reviewed Mar 16, 2026

View reviewed changes

Comment thread src/Models/TreeViewModel.vala Outdated

danirabbit reviewed Mar 16, 2026

View reviewed changes

Comment thread src/Models/TreeViewModel.vala Outdated

stsdc added 8 commits March 19, 2026 13:16

Merge branch 'main' into stsdc/gtk4-treeview

d3265cd

TreeVIewModel: Move classes to separate files

c42c3bb

TreeViewFilter: make chain filters private

3922627

Fix lint

9833f56

Merge branch 'main' into stsdc/gtk4-treeview

ab9bee1

Merge branch 'main' into stsdc/gtk4-treeview

c8b3014

ProcessTreeView: Use bindings to fix list jumps

c07348f

Use correct casting approach

111f4db

stsdc requested a review from danirabbit May 10, 2026 15:33

stsdc requested a review from a team May 10, 2026 16:14

Cleanup and formatting

df026ba

ryonakano reviewed May 18, 2026

View reviewed changes

TreeViewModel: make it singleton

6b80f21

		pid_item_factory.unbind.connect (pid_item_unbind_factory);


		var name_column = new Gtk.ColumnViewColumn (_("Process Name"), name_item_factory) {

		var label = (Gtk.Label) box.get_last_child ();
		var icon = (Gtk.Image) box.get_first_child ();

Uh oh!

Conversation

stsdc commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danirabbit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stsdc commented May 10, 2026

Uh oh!

ryonakano left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stsdc commented Feb 26, 2026 •

edited

Loading