connect domain use cases and implement reactive UI updates#48
Closed
IntFxZen wants to merge 3 commits intoembedded-dev-research:mainfrom
Closed
connect domain use cases and implement reactive UI updates#48IntFxZen wants to merge 3 commits intoembedded-dev-research:mainfrom
IntFxZen wants to merge 3 commits intoembedded-dev-research:mainfrom
Conversation
Member
|
I still have a few technical concerns before merge:
Also, I think this PR would still be easier to review if it were split into a few smaller parts:
|
Contributor
Author
|
Fixed all noted issues (folderId preservation, directory-note cleanup, stable keys for swipe rows). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the app presentation layer to use domain use cases through NotesViewModel (Koin-based injection), replacing local/fallback state handling with use-case-driven flows for directories and notes.
Implemented note deletion via left swipe in the notes list, wired end-to-end through UI events to DeleteNoteUseCase, and improved swipe UX (custom delete container, smoother visuals, progressive behavior, spacing polish).
Added directory management in UI: create directory from a top-bar dialog (via CreateFolderUseCase) and delete directory on long press with confirmation (via DeleteFolderUseCase), including guardrails for non-deletable system folder behavior.
Stabilized app-layer lifecycle/state handling (job cancellation, screen transitions, folder-id mapping for “All Notes”), and cleaned/modernized Koin module wiring for ViewModel + use cases.
Next steps: wire up counters and finish integrating the remaining use cases. Later: rework the UI.