Repository navigation
Make the smoke test app pass on Ember 7 - #1112
Merged
NullVoxPopuli merged 3 commits intoNov 12, 2026
Merged
NullVoxPopuli merged 3 commits into
NullVoxPopuli merged 3 commits into
Conversation
Ember 7 no longer publishes AMD bundles, so the release, beta, and canary scenarios failed in the classic build of the smoke test app. - The channel scenarios get current build tooling: ember-cli 7, ember-cli-babel 8, ember-cli-htmlbars 7, and ember-load-initializers 3, with overrides for nested copies. - The base app moves to ember-cli 5.12, ember-auto-import 2.13, ember-qunit 9, @ember/test-helpers 5, and ember-resolver 13. Older releases import the `ember` module, which Ember 7 removed. - tests/test-helper.js calls `loadTests()` and `setupEmberOnerrorValidation()`, which ember-qunit 9 no longer runs from `start()`. - The Ember 3.28 scenarios pin ember-cli 4.12, ember-qunit 6, and @ember/test-helpers 2. The Ember 4.4 scenario pins ember-qunit 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli
enabled auto-merge
November 12, 2026 18:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 21 21
Lines 516 516
=======================================
Hits 493 493
Misses 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`try:ember` adds release, beta, and canary scenarios from ember-try-config. With the dummy fixture config, nothing replaced them, so they built Ember 7 with the base smoke app tooling and failed. The fixture now takes those three scenarios from the smoke app config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
auto-merge was automatically disabled
November 12, 2026 18:20
Head branch was pushed to by a user without write access
Mocha loads every file under test/, including this fixture, without the smoke app's dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kategengler
approved these changes
Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ember-release,ember-beta, andember-canarysmoke scenarios now pass. Ember 7 no longer publishes AMD bundles, so the classic build of the smoke test app crashed:This failed the
try:eachandtry:embercommands smoke tests on every PR, for example #1110.Changes in
smoke-test-app:ember-cli7,ember-cli-babel8,ember-cli-htmlbars7, andember-load-initializers3. Overrides apply the same versions to nested copies.ember-cli5.12,ember-auto-import2.13,ember-qunit9,@ember/test-helpers5, andember-resolver13. The older releases import theembermodule, which Ember 7 removed.tests/test-helper.jscallsloadTests()andsetupEmberOnerrorValidation().ember-qunit9 no longer runs them fromstart().ember-lts-3.28,ember-classic) pinember-cli4.12,ember-qunit6, and@ember/test-helpers2.ember-source3.28 callsproject.bowerDependencies(), whichember-cli5 removed.ember-lts-4.4pinsember-qunit7.Local checks on Node 22.22.0, from a clean cache:
npx ember try:each: all 9 scenarios pass.npx ember try:ember '4.8.3': all 10 scenarios pass.pnpm lintpasses.The lockfiles changed a lot (
package-lock.jsonandyarn.lock), becausenpm installrewrote both.🤖 Generated with Claude Code