Skip to content

Make the smoke test app pass on Ember 7 - #1112

Merged
NullVoxPopuli merged 3 commits into
ember-cli:mainfrom
NullVoxPopuli-ai-agent:nvp/ember-7-smoke-tests
Nov 12, 2026
Merged

NullVoxPopuli merged 3 commits into
ember-cli:mainfrom
NullVoxPopuli-ai-agent:nvp/ember-7-smoke-tests

Conversation

@NullVoxPopuli-ai-agent

Copy link
Copy Markdown

The ember-release, ember-beta, and ember-canary smoke scenarios now pass. Ember 7 no longer publishes AMD bundles, so the classic build of the smoke test app crashed:

TypeError: Cannot read properties of undefined (reading 'debug')
    at EmberAddon._initVendorFiles (ember-cli/lib/broccoli/ember-app.js:477:38)

This failed the try:each and try:ember commands smoke tests on every PR, for example #1110.

Changes in smoke-test-app:

  • The channel scenarios get current build tooling: ember-cli 7, ember-cli-babel 8, ember-cli-htmlbars 7, and ember-load-initializers 3. Overrides apply the same versions to nested copies.
  • The base app moves to ember-cli 5.12, ember-auto-import 2.13, ember-qunit 9, @ember/test-helpers 5, and ember-resolver 13. The older releases import the ember module, which Ember 7 removed.
  • tests/test-helper.js calls loadTests() and setupEmberOnerrorValidation(). ember-qunit 9 no longer runs them from start().
  • The Ember 3.28 scenarios (ember-lts-3.28, ember-classic) pin ember-cli 4.12, ember-qunit 6, and @ember/test-helpers 2. ember-source 3.28 calls project.bowerDependencies(), which ember-cli 5 removed. ember-lts-4.4 pins ember-qunit 7.

Local checks on Node 22.22.0, from a clean cache:

  • npx ember try:each: all 9 scenarios pass.
  • npx ember try:ember '4.8.3': all 10 scenarios pass.
  • pnpm lint passes.

The lockfiles changed a lot (package-lock.json and yarn.lock), because npm install rewrote both.

🤖 Generated with Claude Code

Ember 7 no longer publishes AMD bundles, so the release, beta, and
canary scenarios failed in the classic build of the smoke test app.

- The channel scenarios get current build tooling: ember-cli 7,
  ember-cli-babel 8, ember-cli-htmlbars 7, and ember-load-initializers 3,
  with overrides for nested copies.
- The base app moves to ember-cli 5.12, ember-auto-import 2.13,
  ember-qunit 9, @ember/test-helpers 5, and ember-resolver 13. Older
  releases import the `ember` module, which Ember 7 removed.
- tests/test-helper.js calls `loadTests()` and
  `setupEmberOnerrorValidation()`, which ember-qunit 9 no longer runs
  from `start()`.
- The Ember 3.28 scenarios pin ember-cli 4.12, ember-qunit 6, and
  @ember/test-helpers 2. The Ember 4.4 scenario pins ember-qunit 7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.54%. Comparing base (75eed15) to head (8a42b9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          21       21           
  Lines         516      516           
=======================================
  Hits          493      493           
  Misses         23       23           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

`try:ember` adds release, beta, and canary scenarios from
ember-try-config. With the dummy fixture config, nothing replaced them,
so they built Ember 7 with the base smoke app tooling and failed. The
fixture now takes those three scenarios from the smoke app config.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
auto-merge was automatically disabled November 12, 2026 18:20

Head branch was pushed to by a user without write access

Mocha loads every file under test/, including this fixture, without the
smoke app's dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NullVoxPopuli
NullVoxPopuli merged commit 88714fd into ember-cli:main Nov 12, 2026
34 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants