Repository navigation
nocontainer hides the test container but keeps it scaled to 640x384 - #1209
Merged
NullVoxPopuli merged 1 commit intoNov 17, 2026
Merged
Conversation
With ?nocontainer, the test container was hidden but kept its default 640x384 size, with #ember-testing scaled to 0.5. Layout-dependent tests therefore ran differently than in a normal run. Apply the ember-testing-container-full-screen class for nocontainer as well, as devmode and fullscreencontainer already do, and update the doc comment. Verified with pnpm lint and the test-app ember test suite (28/28 passing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
?nocontainer(the "Hide container" checkbox),setupTestContaineraddsember-testing-container-hidden, which sets onlyopacity: 0; pointer-events: none. The container keeps its default size: fixed at 640x384, with#ember-testingat 200% andscale(0.5).That small, scaled box exists so you can watch the app next to the QUnit report. A hidden box has no reason to be small. Its size still changes how layout-dependent code behaves: overflow menus collapse, virtualized tables render fewer rows, and coordinates come back scaled. Tests that pass in a normal run then fail only when the container is hidden.
With this PR,
nocontaineralso addsember-testing-container-full-screen, asdevmodeandfullscreencontaineralready do. You can get the same result today with?nocontainer&fullscreencontainer, but the checkbox sets onlynocontainer, and nothing tells users they need both. The hidden container still haspointer-events: none, so clicks reach the QUnit report under it.Evidence from a large Ember app, with a 1440x813 viewport:
?nocontaineralone, the container measures 640x384 at scale 0.5. With this change, it measures 1440x813, the same as?fullscreencontainer.?nocontainer. This change fixed the 16 caused by the container size.elementFromPointstill fail, becausepointer-events: noneis intentional for a hidden container.nocontainer, or pass when run alone.No existing test covers
setupTestContaineror the URL params, so this PR does not add one.pnpm lintpasses, andpnpm test:emberintest-apppasses 28/28.Related: #923.
AI attribution: 🤖 Claude Code using Claude Opus 5.5. Used skills including
gitkrystan-claude-plugin:commit. Reviewed by the author before opening.