Repository navigation
ci: release - #4506
ci: release#4506emdashbot[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
area/admin
area/auth
area/cloudflare
area/core
area/plugins
bot
size/M
cla: signed
labels
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is correct. It consumes the single pending changeset (fresh-comment-pages.md, an emdash patch from #4460) and moves it into packages/core/CHANGELOG.md. It bumps emdash and the fixed-version packages to 1.4.1 and gives each dependent package a matching patch bump. Both reviewers approved and found nothing that needs fixing. The diff contains no code changes. The reviews were static, and no tests, builds, or publishing commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-test
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-loader
@emdash-cms/registry-moderation
@emdash-cms/registry-verification
upgrade-emdash
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-ai-search
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
8d2bec7 to
b7026b4
Compare
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 9030f37 | Nov 11 2026, 10:43 AM |
e82cb5e to
bb0ad27
Compare
There was a problem hiding this comment.
The automated Changesets release approach remains appropriate. This follow-up incorporates the additional media-upload, forms-editor, dev-runtime, and search-availability release notes while retaining the previously reviewed comment-cache fix.
I checked the follow-up against the current PR diff, consumed changesets, package versions, fixed-version configuration, dependency relationships, and release-note claims against relevant implementation. The current PR remains limited to release metadata and changelogs; implementation changes in the follow-up are already on the base branch. There were no earlier findings to resolve, and I found nothing new that needs fixing.
Static review only; no tests, builds, or publishing commands were run.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
bb0ad27 to
db41a8d
Compare
There was a problem hiding this comment.
The automated Changesets release approach remains appropriate and fits EmDash’s release process.
I checked the follow-up against the full PR diff, consumed changesets, fixed-version configuration, package versions, and dependency relationships. I also verified the newly included seed-taxonomy release notes against the locale-aware lookup, translation-group assignment handling, regression tests, and CLI conflict option. The PR itself remains limited to release metadata and changelogs; implementation and catalog changes visible in the follow-up are already on the base branch.
There were no earlier findings to resolve, and I found nothing new that needs fixing.
Static review only; no tests, builds, or publishing commands were run.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
6266927 to
c506288
Compare
There was a problem hiding this comment.
The automated Changesets release approach remains appropriate and fits EmDash’s release process.
I checked the follow-up against the full PR diff, consumed changesets, fixed-version configuration, package versions, and dependency relationships. I also checked the newly included invite-authentication and plugin-activation release notes against the implementation and regression tests. Implementation and catalog changes in the follow-up are already on the base branch; this PR remains limited to release metadata and changelogs.
There were no earlier findings to resolve, and I found nothing new that needs fixing.
Static review only; no tests, builds, or publishing commands were run.
Follow-up review by openai/gpt-6.1-sol, scoped to the changes since the last review.
c506288 to
4e52e8e
Compare
33d9d77 to
ac96595
Compare
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing carries over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, driven by the minor changesets. Independent packages get the patch bumps their changesets request, and packages with no changeset of their own get a patch bump because a dependency changed. All 101 pending changesets are consumed and reflected in the changelogs. The changelog archives and their links are consistent. Entries with upgrade risk, including the plugin KV migration, the client media type changes and the cloudflare exact peer dependency, keep their upgrade guidance. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2296 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing carries over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, driven by the minor changesets. Independent packages get patch bumps, either from their own changesets or because a dependency changed. The pending changesets are consumed and reflected in the changelogs, and the changelog archive chains and links are consistent. Upgrade guidance for risky entries, such as the plugin KV migration, is retained. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2345 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing carries over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0. Independent packages get patch bumps, either from their own changesets or because a dependency changed. All 104 pending changesets are consumed and their prose is retained in the changelogs. Archive links and workspace dependency declarations are consistent, and the upgrade guidance for the plugin KV migration is kept. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2378 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing carries over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, and independent packages get patch bumps. All pending changesets are consumed and their prose is kept in the changelogs. Archive links and workspace dependency declarations are consistent. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2395 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing is carried over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, and independent packages get patch bumps. All 108 pending changesets are consumed and their prose is kept in the package changelogs. Changelog archive links and workspace dependency declarations are consistent. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2773 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing is carried over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, and the independent packages get patch bumps. All pending changesets are consumed and their prose is kept in the package changelogs. Changelog archive links and workspace dependency declarations are consistent. Both reviews were static only; no tests, builds or publish commands were run. The reviewers gave different counts of consumed changesets (108 against 109), but neither raised this as a problem.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2815 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing is carried over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, and the independent packages get patch bumps. All 110 pending changesets are consumed and their prose is kept in the package changelogs. Changelog archive links, the cloudflare emdash peer dependency and workspace dependency declarations are consistent. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2820 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
This is the standard automated Changesets release PR, and the approach is right. Both reviewers approved with no findings, and nothing carries over from the prior review. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves together from 1.4.0 to 1.5.0, and the independent packages get patch bumps. All pending changesets are consumed and their prose is kept in the package changelogs. Changelog archive links, the cloudflare emdash peer dependency and the workspace dependency declarations are consistent. Both reviews were static only; no tests, builds or publish commands were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2823 lines) was too large for a scoped follow-up, so this is a full review.
There was a problem hiding this comment.
The automated Changesets release is the right approach. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) consistently moves from 1.4.0 to 1.5.0, and the independent packages get patch bumps. Changesets are consumed, archive links and workspace dependencies are consistent, and neither reviewer found a release-version or dependency blocker. One generated changelog entry needs correction: issue auto-linking corrupted two CSS color literals in the core changelog. The reviewers differed on this point. anthropic/claude-opus-5-5 approved with no findings, while openai/gpt-6.1-sol raised the finding below, so it is kept. Both reviews were static only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (2861 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Preserve these hexadecimal colors as literal code. Changesets interpreted the numeric colors as issue references and inserted Markdown links inside the backticks. Readers therefore see [#374151](...) and [#111827](...) rather than valid CSS colors. The deleted changeset and the component styles contain the correct literals. Only openai/gpt-6.1-sol raised this; anthropic/claude-opus-5-5 did not mention it.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
The automated Changesets release is the right approach. The fixed group (emdash, admin, auth, blocks, cloudflare, gutenberg-to-portable-text, x402, create-emdash) moves consistently from 1.4.0 to 1.5.0, and the independent packages get patch bumps. Changesets are consumed, and both reviewers found no release-version or dependency problems. One finding from the previous review is still unfixed. In packages/core/CHANGELOG.md, Changesets auto-linked two CSS hex colors as issue references inside code spans, so readers see broken links instead of valid colors. Both reviewers confirmed this is still present at this head and that no fix or author reply was supplied. Both reviews were static only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3279 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from the last review. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a CSS color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
Edits on this branch may be overwritten when the action regenerates the PR. If that happens, change the source changeset on main so the color values don't look like issue numbers to Changesets, for example `rgb(55 65 81)` or `color: #374151`.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
The automated Changesets release is the right approach. The fixed group moves consistently from 1.4.0 to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the changelog archives link correctly. Neither reviewer found other release-metadata problems. One issue remains unfixed from the earlier review, with no author reply: in packages/core/CHANGELOG.md, Changesets turned the CSS colors #374151 and #111827 into issue links inside code spans, so readers see broken links instead of colors. Both reviewers raised it again. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3378 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from the previous review. Changesets read the CSS colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The consumed changeset and the component styles have the correct literals.
The action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset on main (comments-dark-mode-styles.md) so the colors don't look like issue references, for example rgb(55 65 81) or color: #374151.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
The automated Changesets release is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and dependency metadata and changelog archive links check out. One issue is still open from the previous review, with no author reply: packages/core/CHANGELOG.md shows the CSS colors #374151 and #111827 as issue links inside code spans, so readers see broken links instead of colors. This is the only place it happens. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3388 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from the previous reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
The action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset on main so the colors don't look like issue references, for example rgb(55 65 81) or color: #374151.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Using the automated Changesets release is the right approach. The fixed group moves consistently from 1.4.0 to 1.5.0 and independent packages get patch bumps. Consumed changesets are removed, and dependency metadata and changelog archive links check out. Both reviewers found one problem, which was raised in earlier reviews and has no author reply: packages/core/CHANGELOG.md lines 99–100 still show the CSS colors #374151 and #111827 as issue links inside code spans. Readers see broken links to nonexistent issues instead of colors. The fix should also be made in the source changeset on main, because the release action may overwrite edits on this branch. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3422 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
The action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset on main so the colors don't look like issue references, for example rgb(55 65 81) or color: #374151. One reviewer also suggested a follow-up changeset on main, or fixing the published CHANGELOG after release, if an edit here doesn't stick.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Using the automated Changesets release is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and dependency metadata and changelog archive links check out. One problem remains from earlier reviews, with no author reply: in packages/core/CHANGELOG.md, the CSS colors #374151 and #111827 were turned into issue links inside code spans. Readers see links to nonexistent issues instead of colors. The fix should also be made in the source changeset on main, because regenerating the release PR may overwrite edits on this branch. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3438 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
The action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset on main so the colors don't look like issue references, for example rgb(55 65 81) or color: #374151. If an edit here doesn't stick, a follow-up changeset on main, or fixing the published CHANGELOG after release, is another option.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Releasing through the automated Changesets PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the dependency metadata and changelog archives look correct. One defect from earlier reviews remains open, with no author reply. In packages/core/CHANGELOG.md, Changesets turned the CSS colors #374151 and #111827 into issue links inside code spans. The fix should also be made in the source changeset on main, because regenerating the release PR may overwrite an edit made only on this branch. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3470 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) and rgb(17 24 39), or color: #374151. If an edit here doesn't stick, a follow-up changeset on main or fixing the published CHANGELOG after release are other options.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Releasing through the automated Changesets PR is the right approach. Both reviewers found the fixed group moving consistently to 1.5.0, independent packages getting patch bumps, and consumed changesets removed. One defect from earlier reviews is still open, with no author reply. In packages/core/CHANGELOG.md, the CSS colors #374151 and #111827 still show up as issue links inside code spans. Fixing only this branch may not stick, because the release action regenerates the PR. The source changeset comments-dark-mode-styles.md on main needs the same fix. This was a static review only; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3499 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The deleted .changeset/comments-dark-mode-styles.md and the component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action may overwrite edits on this branch when it regenerates the PR. To make the fix stick, also change the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) and rgb(17 24 39), or color: #374151. If an edit here doesn't stick, a follow-up changeset on main or fixing the published CHANGELOG after release are other options.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Shipping the release through the automated Changesets PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and the consumed changesets are removed. Both reviewers found one defect, carried over from earlier reviews with no author reply. In packages/core/CHANGELOG.md, Changesets turned the CSS colors #374151 and #111827 into issue links inside code spans. A fix on this branch alone will be lost when the release action regenerates the PR, so the source changeset comments-dark-mode-styles.md on main also needs rewording. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3605 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The source changeset and the component styles have the correct literals.
The release action rebuilds this PR, so an edit on this branch alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) and rgb(17 24 39), or color: #374151. Another option is a follow-up changeset on main, or fixing the published CHANGELOG after the release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the changelog archive links are consistent. Two issues remain. First, the CSS-color link corruption in the core changelog (reported in earlier reviews, no author reply) is still unfixed. Second, one reviewer found a documentation gap affecting SMTP setup on Workers with older compatibility dates. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3652 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The source changeset and component styles have the correct literals. Reviewers found no other package changelog with this problem.
The release action rebuilds this PR, so an edit on this branch alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. | ||
| - Optional: `EMAIL_SMTP_PORT` (587 when empty), `EMAIL_SMTP_SECURE`, `EMAIL_SMTP_FROM`, `EMAIL_SMTP_FROM_NAME`, `EMAIL_SMTP_FROM_EMAIL` and `EMAIL_SMTP_REPLY_TO`. |
There was a problem hiding this comment.
[needs fixing] Raised only by openai/gpt-6.1-sol; anthropic/claude-opus-5-5 did not mention it. The Workers environment-variable setup is missing a prerequisite. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so an existing Worker pinned to an older date can set all the listed secrets and still have no SMTP provider configured. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Add the required compatibility date or nodejs_compat_populate_process_env flag here and in the matching admin changelog entry. The canonical Cloudflare SMTP guide already documents this requirement; linking to it would also give upgraders the complete setup instructions.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the archive links are consistent. Both reviewers found the same two unresolved issues from earlier reviews, neither with an author reply. First, the core changelog still has CSS hex colors corrupted into issue links. Second, the SMTP entry omits the Workers environment-variable prerequisite. Neither reviewer found anything new. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3661 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] This is still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the backticks. Readers of the 1.5.0 changelog see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The source changeset and component styles have the correct literals.
The release action regenerates this branch, so an edit here alone may not last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry. Link the Cloudflare SMTP guide, which already documents it. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Reviewers anchored this at line 65 (anthropic/claude-opus-5-5) and line 71 (openai/gpt-6.1-sol, and the earlier review at line 72); the entry is the same.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and consumed changesets are removed. Both reviewers agree that two documentation defects from earlier reviews remain unfixed, with no author reply. First, the core changelog still renders the CSS hex colors as issue links inside code spans. Second, the SMTP entry still omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes should also be made in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3669 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The source changeset and component styles have the correct literals.
The release action regenerates this branch, so an edit here alone may not last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry. Link the Cloudflare SMTP guide, which already documents it. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Reviewers anchored this at line 71 (both reviewers in this pass) and at line 65 or 72 in earlier passes; the entry is the same.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and consumed changesets are removed. Both reviewers agree that two documentation defects from earlier reviews are still unfixed, with no author reply. The core changelog still renders the CSS hex colors as issue links inside code spans, and the SMTP entry still omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also need to be made in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3678 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md:85). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Reviewers anchored this at line 65 (anthropic/claude-opus-5-5) and line 71 (openai/gpt-6.1-sol); the entry is the same.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the changelog archive links are intact. Both reviewers agree that two documentation defects from earlier reviews are still unfixed, with no author reply. First, the core changelog still renders the CSS hex colors #374151 and #111827 as issue links inside code spans. Second, the SMTP entry still omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also need to be made in the source changesets on main (comments-dark-mode-styles.md and smtp-email-transport.md). This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3689 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md:85). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Reviewers anchored this at line 65 (anthropic/claude-opus-5-5) and line 71 (openai/gpt-6.1-sol); the entry is the same.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and the changelog archive links are intact. Both reviewers agree that two documentation defects from earlier reviews are still present at this head, and there is no author reply to either. First, the core changelog still renders the CSS hex colors #374151 and #111827 as issue links inside code spans. Second, the SMTP entry still omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also need to be made in the source changesets on main (comments-dark-mode-styles.md and smtp-email-transport.md). This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3688 lines) was too large for a scoped follow-up, so this is a full review.
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md:85). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Earlier passes anchored this at line 65 or 72; the entry is the same.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, consumed changesets are removed, and no other package changelog has bad auto-links. Both reviewers agree that two documentation defects from earlier reviews are still present at this head, with no author reply to either. First, the core changelog renders the CSS hex colors #374151 and #111827 as issue links inside code spans. Second, the SMTP entry omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also need to be made in the source changesets on main (comments-dark-mode-styles.md and smtp-email-transport.md). This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3698 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39) or color: #374151. Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md:85). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Make the change in the source changeset smtp-email-transport.md on main so it survives regeneration. Reviewers anchored this at line 71 (openai/gpt-6.1-sol) and line 71 with the admin entry noted (anthropic/claude-opus-5-5); earlier passes used lines 65 or 72, but the entry is the same.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and the consumed changesets are removed. Both reviewers agree that two documentation defects from earlier reviews are still present at this head, with no author reply or fix to either. The core changelog renders the CSS hex colors as issue links inside code spans, and the SMTP entry omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also belong in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3732 lines) was too large for a scoped follow-up, so this is a full review.
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. loadSmtpConfigFromEnv() reads these values only from process.env. On Workers with compatibility dates before 2025-04-01, nodejs_compat alone does not populate it with deployment secrets. A Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving SMTP settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md; earlier passes cited lines 85 and 103). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Change the source changeset smtp-email-transport.md on main so the fix survives regeneration.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39). Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and the consumed changesets are removed. Both reviewers agree that two documentation defects from earlier reviews are still present at this head, with no author reply or fix to either. The core changelog renders the CSS hex colors as issue links inside code spans, and the SMTP entry omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also belong in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3748 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39). Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets. loadSmtpConfigFromEnv() reads these variables only from process.env, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md, around lines 85-103). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Change the source changeset smtp-email-transport.md on main so the fix survives regeneration.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and the consumed changesets are removed. Both reviewers agree that two documentation defects from earlier reviews are still present at this head, with no author reply or fix to either. The core changelog renders the CSS hex colors as issue links inside code spans, and the SMTP entry omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also belong in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3752 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets read the hex colors #374151 and #111827 as issue numbers and put Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39). Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#2156](https://github.com/emdash-cms/emdash/pull/2156) [`25574da`](https://github.com/emdash-cms/emdash/commit/25574da51e580b95799a0ec3d43f680730d33f5f) Thanks [@swissky](https://github.com/swissky)! - Adds a built-in SMTP email provider. It delivers through any standard SMTP server, such as Brevo, Office 365, Fastmail, Amazon SES or a self-hosted Postfix, on Node and on Cloudflare Workers with the `nodejs_compat` flag. | ||
|
|
||
| #### What should I do? | ||
| #### Configure | ||
|
|
||
| Entries in those collections that were saved before this release can still be missing from **Used in** after you upgrade. Open **Settings → Media usage tracking** and wait until it shows **Ready**. If it shows **Needs attention** instead, repair each affected collection once: | ||
| Choose **SMTP** under Settings → Email, or set environment variables: | ||
|
|
||
| ```sh | ||
| npx emdash media repair-usage --collection <collection> | ||
| ``` | ||
|
|
||
| - [#4285](https://github.com/emdash-cms/emdash/pull/4285) [`57abb5c`](https://github.com/emdash-cms/emdash/commit/57abb5c445e0627acff748999e2ca35b75d1e102) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes menus showing dead links to entries that are in the trash or not published. `getMenu()` leaves those items out. Any item `getMenu()` leaves out now takes its child items with it, instead of moving them to the top level of the menu. In edit mode, menus still link to unpublished entries. With the object cache enabled, a cached menu now refreshes when an entry or taxonomy term it links to changes. | ||
|
|
||
| - [#4365](https://github.com/emdash-cms/emdash/pull/4365) [`e1c4a87`](https://github.com/emdash-cms/emdash/commit/e1c4a87a7b3c634b96d7274dbd728975b9382b05) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes creating a child menu item through the menu items API on PostgreSQL. A request with a `parentId` and no `sortOrder` failed; the item is now placed after its existing siblings. | ||
|
|
||
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. The entry says SMTP works on Workers with the nodejs_compat flag, but loadSmtpConfigFromEnv() reads these variables only from process.env. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md, around lines 85-104). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Change the source changeset smtp-email-transport.md on main so the fix survives regeneration.
There was a problem hiding this comment.
Shipping through the automated Changesets release PR is the right approach. The fixed group moves consistently to 1.5.0, independent packages get patch bumps, and the consumed changesets are removed. Two documentation defects from earlier reviews are still present at this head, with no author reply or fix. The core changelog renders the CSS hex colors #374151 and #111827 as issue links inside code spans, and the SMTP entry omits the Workers prerequisite for process.env. The release action regenerates this branch, so both fixes also belong in the source changesets on main. This was a static review; no tests, builds or publishes were run.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol. The change since the last review (3766 lines) was too large for a scoped follow-up, so this is a full review.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | ||
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
There was a problem hiding this comment.
[needs fixing] Still unfixed from earlier reviews. Changesets reads the hex colors #374151 and #111827 as issue numbers and puts Markdown links inside the code spans. Readers see [#374151](https://github.com/emdash-cms/emdash/issues/374151) instead of a color, and the links point to issues that don't exist. The component styles (Comments.astro, CommentForm.astro) have the correct literals.
The release action regenerates this branch, so an edit here alone won't last. Also reword the source changeset comments-dark-mode-styles.md on main so the values don't look like issue references, for example rgb(55 65 81) / rgb(17 24 39). Other options are a follow-up changeset on main, or fixing the published CHANGELOG after release.
| - Updates `Comments` to use a dark border color (`[#374151](https://github.com/emdash-cms/emdash/issues/374151)`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `[#111827](https://github.com/emdash-cms/emdash/issues/111827)` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. | |
| - Updates `Comments` to use a dark border color (`#374151`, overridable via `--ec-comment-border-color-dark`) for separators and reaction buttons. | |
| - Inverts `.ec-comment-form-submit` in dark mode (`#f3f4f6` background, `#111827` text, overridable via `--ec-form-submit-bg-dark` and `--ec-form-submit-color-dark`) for high contrast against dark backgrounds. |
| - [#4208](https://github.com/emdash-cms/emdash/pull/4208) [`bed3e42`](https://github.com/emdash-cms/emdash/commit/bed3e421e02429f51c2717fe0aa90ea5340ff921) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes content list search, in the admin and through the content list API's `q` parameter, failing when the collection has a reference field named `title` or `name`. The search now leaves out a reference field bound to a relation and matches the entry's other fields. | ||
|
|
||
| - [#4205](https://github.com/emdash-cms/emdash/pull/4205) [`4409acb`](https://github.com/emdash-cms/emdash/commit/4409acb10736c2bf8031bbf29c761dc594e919ed) Thanks [@danielmlr](https://github.com/danielmlr)! - Fixes entry creation, entry saves and content-list search failing with `no such column` in a collection that has a reference field marked `searchable`. Adding such a field to a search-enabled collection failed, and after a seed turned search on, creating or saving any entry in that collection failed. Site search and content-list search now ignore the `searchable` flag on a reference field bound to a relation. | ||
| - Required: `EMAIL_SMTP_HOST`, `EMAIL_SMTP_USER` and `EMAIL_SMTP_PASS`. |
There was a problem hiding this comment.
[needs fixing] The Workers prerequisite is still missing. The entry says SMTP works on Workers with nodejs_compat, but loadSmtpConfigFromEnv() reads these variables only from process.env. For compatibility dates before 2025-04-01, nodejs_compat alone does not populate process.env with deployment secrets, so a Worker pinned to an older date can set every listed secret and still have no SMTP provider. Saving settings also needs EMDASH_ENCRYPTION_KEY through that same path.
Name the required compatibility date (2025-04-01 or later) or the nodejs_compat_populate_process_env flag here and in the matching admin changelog entry (packages/admin/CHANGELOG.md). Link the Cloudflare SMTP guide, which already documents it. Other 1.5.0 entries, such as packages/cloudflare/CHANGELOG.md:429, already state the requirement. Change the source changeset smtp-email-transport.md on main so the fix survives regeneration. Reviewers anchored this entry at line 77 (anthropic/claude-opus-5-5) and line 83 (openai/gpt-6.1-sol); it is the same entry.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@emdash-cms/admin@1.5.0
emdash@1.5.0
@emdash-cms/auth@1.5.0
@emdash-cms/auth-atproto@0.2.51
@emdash-cms/blocks@1.5.0
@emdash-cms/cloudflare@1.5.0
@emdash-cms/gutenberg-to-portable-text@1.5.0
@emdash-cms/plugin-cli@0.13.6
@emdash-cms/plugin-test@0.2.12
@emdash-cms/plugin-types@0.6.1
@emdash-cms/plugin-ai-moderation@0.2.3
@emdash-cms/plugin-ai-search@0.1.1
@emdash-cms/plugin-atproto@0.2.5
@emdash-cms/plugin-audit-log@0.2.4
@emdash-cms/plugin-embeds@0.1.59
@emdash-cms/plugin-field-kit@0.1.3
@emdash-cms/plugin-forms@0.2.13
@emdash-cms/registry-client@0.7.2
@emdash-cms/registry-lexicons@0.7.1
@emdash-cms/registry-loader@0.1.4
@emdash-cms/registry-verification@0.3.5
@emdash-cms/sandbox-workerd@0.9.7
create-emdash@1.5.0
@emdash-cms/x402@1.5.0