Repository navigation
Conversation
ostenbom
added
ready-for-ci
🔎 OpenObserve Code ReviewCaution ⛔ Not reviewedThe review API key is not set. OpenObserve Code Review did not run for this PR — this is a CI misconfiguration, not a skip. Please confirm the review secrets are provisioned. |
1 similar comment
🔎 OpenObserve Code ReviewCaution ⛔ Not reviewedThe review API key is not set. OpenObserve Code Review did not run for this PR — this is a CI misconfiguration, not a skip. Please confirm the review secrets are provisioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing product browser suite cannot run in this fork because its build, test, and report jobs require upstream private runners. Use GitHub-hosted Ubuntu runners while preserving the native Playwright runner, Chromium installation, full manifest selection, per-shard application instances, fixtures, retries, and assertions.
The server uses a debug Cargo build as required by the repository instructions, with debug symbols and incremental compilation disabled to fit hosted runners. Both benchmark configurations will use this same build setup. The build timeout is increased for the smaller runner; it is not a measured duration. Optional upstream Kinora uploads require explicit opt-in outside upstream. No product or test source changes.
Validation: all 22 matrix-selection contract tests pass locally; required cargo formatting and full workspace/all-targets clippy passed. Full native Playwright attempt 1 completed with failures: 1,906 passed, 14 flaky passes, 139 skipped, and 3 failed (2,062 total), across all 29 groups. The failures persisted through four attempts each: two schema-drawer visibility checks in Streams/schema.spec.js (lines 156 and 229) and the streaming join-query refresh-button timeout in Streams/streaming.spec.js (line 58). Assertions and tests are unchanged. The existing auto-rerun workflow subsequently retried the failed group; that partial rerun is separate from the full benchmark sample. Attempt 2 subsequently passed, recovering all 29 groups without source changes. The initial three failures are therefore transient under this setup, despite exhausting the original in-process retries. This PR remains open as the reproducible baseline for a separate stacked Endform migration; neither PR will be merged.
Evidence: baseline commit
6a7114856cb7de1cb532602a56b4ceba062de2cb; completed attempt 1, merged-report-1 artifact. Whole workflow: 57m44s; test-stage wall-clock critical path: 35m43s, including later groups waiting for GitHub runners. Build job: 18m18s (binary/frontend build step: 12m25s). Queue times for test jobs: 2s–27m55s. One full completed sample; no stable-performance claim.Passing recovery attempt 2. This reruns failed jobs only and is not another full-suite timing sample.