fix(large-response-middleware): use Buffer.byteLength for accurate UTF-8 size measurement#7
Merged
Conversation
…F-8 size measurement payload.length counts JavaScript string characters, which undercounts multi-byte UTF-8 content. This caused the middleware to underestimate response sizes and miss the error threshold, allowing oversized payloads through to the Lambda runtime which then rejected them with a 413. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payload.length * 1.0withBuffer.byteLength(payload, 'utf8')for accurate byte countingnodetotsconfig.jsontypes soBufferresolves without a TS errorProblem
String.prototype.lengthcounts JavaScript UTF-16 code units, not bytes. For responses containing multi-byte UTF-8 characters the middleware was significantly underestimating the actual payload size, causing it to miss the error threshold and pass an oversized response to the Lambda runtime — which then hard-rejected it with:This meant the client received a 413 even when it had correctly sent
Accept: application/large-response.vnd+json.Test plan
npm test)tsc --noEmitclean🤖 Generated with Claude Sonnet 4.6