Repository navigation
Prepare Epoch widget for Miden mainnet - #15
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
React Doctor found 1 new issue in 1 file · 1 warning · score 85 / 100 (Great) · 0 fixed · vs Reviewed by React Doctor for commit |
Signed-off-by: Manank Patni <manank321@gmail.com>
Signed-off-by: Manank Patni <manank321@gmail.com>
Signed-off-by: Manank Patni <manank321@gmail.com>
| @@ -122,7 +127,7 @@ export function useGaslessWallet({ | |||
| } finally { | |||
| setChecking(false); | |||
| } | |||
| }, [allowGasless, walletClient, address, chainIdForCheck]); | |||
| }, [allowGasless, apiBaseUrl, walletClient, address, chainIdForCheck, rpcUrls]); | |||
There was a problem hiding this comment.
React Doctor · react-doctor/exhaustive-deps (warning)
useCallback re-runs whenever apiBaseUrl changes even though it never uses it.
Fix → Don't blindly add missing dependencies. Read the hook callback first.
Bad:
useEffect(() => {
setCount(count + 1);
}, [count]);
Better:
useEffect(() => {
setCount((currentCount) => currentCount + 1);
}, []);
If the missing value is recreated every render, move it inside the hook or stabilize it before adding it to deps.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification