Repository navigation
Fix mainnet Earn signing and private Miden withdrawals - #16
Open
Abhimanyu121 wants to merge 2 commits into
Open
Abhimanyu121 wants to merge 2 commits into
Abhimanyu121 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
React Doctor found 1 new issue in 1 file · 1 warning · score 85 / 100 (Great) · 0 fixed · vs Reviewed by React Doctor for commit |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainnet Earn rejected approved MetaMask-delegated local accounts and silently ignored Smart Withdraw clicks for private Miden recipients. Apply a version-pinned pnpm patch to epoch-intents-sdk 1.0.39 that recognizes the verified MetaMask wallet and DelegationManager on Ethereum, Optimism, Polygon, and Base. All workspace consumers use the recorded patch until an SDK release includes the source fix.
Allow opening Local signer while an injected wallet is connected, switch the active EVM connection when a valid local key is submitted, and expose Clear local signer to discard the memory-only key. Pin withdrawal quotes to the position chain, avoid quoting before a network switch, surface execution errors, and stop polling when an intent fails.
Fix the idle Smart Withdraw click for private Miden recipients: the frontend incorrectly required a public recipient, even though the backend sends public P2ID notes that can target a private account. The rejected recipient routed the CTA into connectMiden, where an already-connected wallet returned immediately, while the detail button still read Confirm Smart Withdraw. Accept either recipient storage mode, preserve the missing-recipient guard, and use the real CTA label for every non-submit action.
Validation: all 39 widget unit tests and 6 demo signer/note tests pass; library build, demo typecheck, and staged demo build pass. The native Miden SDK successfully constructs a public P2ID note for the exact private recipient. A live quote-only run through the installed SDK obtains both Aave Base withdrawal and Base-USDC-to-Miden-USDCX quotes for 0.01 USDC (bridge quote output 0.009918 USDCX); transaction execution is intercepted and wallet RPC is blocked during this check. The deployed public bundle matches the built artifact by SHA-256 and contains the corrected recipient guard and CTA labels. Mainnet delegation is recognized on Base and Optimism with no setup required. No funded withdrawal was submitted. The repository-requested graphify update could not run because graphify is not installed.