Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix prototype pollution in label parsing#22

Open
ericbfriday wants to merge 1 commit into
masterfrom
sentinel-fix-prototype-pollution-3511306698593960999
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix prototype pollution in label parsing#22
ericbfriday wants to merge 1 commit into
masterfrom
sentinel-fix-prototype-pollution-3511306698593960999

Conversation

@ericbfriday
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Prototype pollution in Lua labels parsing via __proto__ causing unexpected interactions with Object.prototype.
🎯 Impact: This could be exploited by user-supplied input where a label like ::__proto__:: could pollute the internal parser representation or cause parsing failures.
πŸ”§ Fix: Replaced standard object initialization {} with Object.create(null) for the labels dictionary in luaparse.js.
βœ… Verification: Tested parser manually with ::__proto__:: and ran all existing suite tests with npm run test which completed without regressions.


PR created automatically by Jules for task 3511306698593960999 started by @ericbfriday

Copilot AI review requested due to automatic review settings May 21, 2026 00:01
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR mitigates a prototype pollution risk in the Lua label (::label::) tracking logic by ensuring label names are stored in a dictionary that does not inherit from Object.prototype.

Changes:

  • Initialize scope.labels with Object.create(null) to prevent special keys like __proto__ from affecting the object prototype chain.
  • Add a Sentinel note documenting the vulnerability, lesson learned, and prevention guidance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
luaparse.js Uses a null-prototype dictionary for label storage to prevent prototype pollution via user-controlled label names.
.jules/sentinel.md Documents the identified prototype pollution vector and the chosen mitigation pattern.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants