Repository navigation
ci: give ASAN separate bounded build and test budgets - #57
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 127 127
Lines 29649 29649
=======================================
Hits 26326 26326
Misses 3323 3323 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause (live master failure)
The Linux
Buildrun on merged masterc80a1e0351ee9675f0344e12f24a433c380d33d7was cancelled because its ASAN job exhausted the one-hour job budget, not because
of a failed test or a reported sanitizer violation.
The runner cancelled the job at 20:57:23 Asia/Shanghai while
test_os.test_os_datewas running: 1317 tests had passed, 1318 had started, with no failed-test or
ASAN error markers in the full log. Tests were still progressing immediately before cancellation.
the shared job budget for the instrumented suite.
a3ec65bhad already passed ASAN (30.47 minutes total):https://github.com/esrrhs/fakelua/actions/runs/43852311987 . The other current
master build variants, Windows, macOS and Fuzz completed successfully.
Change
Only
.github/workflows/build.ymlchanges:Test (60 minutes) steps. Neither step becomes unbounded; a genuine stalled
test run still times out independently of compilation.
matrix variants.
unit_testsstill runs the complete suite, including MySQL/Redis,followed by the CLI lifecycle check. There is no retry, filter, skip or continue-on-error.
CPM_SOURCE_CACHE, and ASAN'sexisting
ASAN_OPTIONS=detect_leaks=0across the new step boundary.No runtime source changes, sanitizer weakening, unrelated cleanup, or merge is included.
Validation
actionlintv1.7.7 passes on the complete changed workflow.flags and exact original test/CLI command suffix.
bash -npasses for original/build/test scripts rendered for all four variants;executed environment-prefix checks confirm ASAN/CPM settings are preserved for each.
(
jitter.gcc_cache_*:native.gcc_cache_*:exception.gcc_cache_*, 17.258 seconds).This is a smoke check, not a claim to reproduce the full ASAN CI run locally.
git diff --checkpasses. No C/C++ file is touched, so no clang-format changes are needed.The new PR's full CI must confirm completion under the repaired budgets. The cancelled
master job was not blindly rerun. Original unrelated untracked coverage/log files remain untouched.