Skip to content

ci: give ASAN separate bounded build and test budgets - #57

Merged
esrrhs merged 1 commit into
masterfrom
fix/asan-ci-time-budget
Nov 16, 2026
Merged

esrrhs merged 1 commit into
masterfrom
fix/asan-ci-time-budget

Conversation

@esrrhs

@esrrhs esrrhs commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Root cause (live master failure)

The Linux Build run on merged master c80a1e0351ee9675f0344e12f24a433c380d33d7
was cancelled because its ASAN job exhausted the one-hour job budget, not because
of a failed test or a reported sanitizer violation.

  • Run: https://github.com/esrrhs/fakelua/actions/runs/43862208550
  • ASAN job: https://github.com/esrrhs/fakelua/actions/runs/43862208550/job/133281613258
  • GitHub's check annotation explicitly says: “The job has exceeded the maximum execution time of 1h0m0s.”
  • Build completed and all 1715 tests began at 20:16:33 Asia/Shanghai on Nov 16.
    The runner cancelled the job at 20:57:23 Asia/Shanghai while test_os.test_os_date
    was running: 1317 tests had passed, 1318 had started, with no failed-test or
    ASAN error markers in the full log. Tests were still progressing immediately before cancellation.
  • Setup/cold build consumed about 19 minutes, leaving only about 41 minutes of
    the shared job budget for the instrumented suite.
  • The identical source tree at pre-merge a3ec65b had already passed ASAN (30.47 minutes total):
    https://github.com/esrrhs/fakelua/actions/runs/43852311987 . The other current
    master build variants, Windows, macOS and Fuzz completed successfully.

Change

Only .github/workflows/build.yml changes:

  • Give ASAN only a 120-minute job budget; debug/release/coverage retain 60 minutes.
  • Split the existing combined Build step into separate Build (60 minutes) and
    Test (60 minutes) steps. Neither step becomes unbounded; a genuine stalled
    test run still times out independently of compilation.
  • Preserve all original test/CLI commands, build flags, service definitions and
    matrix variants. unit_tests still runs the complete suite, including MySQL/Redis,
    followed by the CLI lifecycle check. There is no retry, filter, skip or continue-on-error.
  • Preserve the original test working directory, CPM_SOURCE_CACHE, and ASAN's
    existing ASAN_OPTIONS=detect_leaks=0 across the new step boundary.

No runtime source changes, sanitizer weakening, unrelated cleanup, or merge is included.

Validation

  • actionlint v1.7.7 passes on the complete changed workflow.
  • Parsed-YAML comparisons verify the unchanged matrix/services/other steps, compiler
    flags and exact original test/CLI command suffix.
  • bash -n passes for original/build/test scripts rendered for all four variants;
    executed environment-prefix checks confirm ASAN/CPM settings are preserved for each.
  • Existing Release binary: 28/28 focused cache/native/exception tests passed
    (jitter.gcc_cache_*:native.gcc_cache_*:exception.gcc_cache_*, 17.258 seconds).
    This is a smoke check, not a claim to reproduce the full ASAN CI run locally.
  • git diff --check passes. No C/C++ file is touched, so no clang-format changes are needed.

The new PR's full CI must confirm completion under the repaired budgets. The cancelled
master job was not blindly rerun. Original unrelated untracked coverage/log files remain untouched.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.79%. Comparing base (c80a1e0) to head (1aa7b01).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         127      127           
  Lines       29649    29649           
=======================================
  Hits        26326    26326           
  Misses       3323     3323           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esrrhs
esrrhs merged commit 5ae28f0 into master Nov 16, 2026
9 checks passed
@esrrhs
esrrhs deleted the fix/asan-ci-time-budget branch November 16, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants